fix: remove lodash sortBy, reduce, isEqual usage (lerna#4206)

Author: JamesHenry

libs/commands/version/src/lib/version-create-release.spec.ts

@@ -4,7 +4,6 @@ import {
   recommendVersion as _recommendVersion,
 } from "@lerna/core";
 import { commandRunner, initFixtureFactory } from "@lerna/test-helpers";
-import { isEqual } from "lodash";
 
 jest.mock("@lerna/core", () => require("@lerna/test-helpers/__mocks__/@lerna/core"));
 
@@ -26,7 +25,13 @@ jest.mock("execa", () => {
 
   const mockExeca = (...args) => {
     // assume there are changes if git diff is called
-    if (args[0] === "git" && isEqual(args[1], ["diff", "--staged", "--quiet"])) {
+    if (
+      args[0] === "git" &&
+      args[1].length === 3 &&
+      args[1][0] === "diff" &&
+      args[1][1] === "--staged" &&
+      args[1][2] === "--quiet"
+    ) {
       return Promise.reject(new Error("Changes found"));
     }
 

libs/core/src/lib/command/create-project-graph-with-packages.ts

@@ -1,6 +1,5 @@
 import { ProjectFileMap, ProjectGraph, ProjectGraphProjectNode, workspaceRoot } from "@nx/devkit";
 import { readJson } from "fs-extra";
-import { reduce, sortBy } from "lodash";
 import minimatch from "minimatch";
 import { resolve } from "npm-package-arg";
 import { join } from "path";
@@ -49,7 +48,7 @@ export async function createProjectGraphWithPackages(
     localPackageDependencies: {},
   };
   const projectLookupByPackageName: Record<string, string> = {};
-  const sortedTuples = sortBy(tuples, (t) => t[0].data.root);
+  const sortedTuples = [...tuples].sort((a, b) => a[0].data.root.localeCompare(b[0].data.root));
   sortedTuples.forEach(([node, manifest]) => {
     let pkg: Package | null = null;
     if (manifest) {
@@ -63,11 +62,15 @@ export async function createProjectGraphWithPackages(
   });
 
   // order dependencies to create consistent results when iterating over them
-  projectGraphWithOrderedNodes.dependencies = reduce(
-    sortBy(Object.keys(projectGraphWithOrderedNodes.dependencies)),
-    (prev, next) => ({ ...prev, [next]: projectGraphWithOrderedNodes.dependencies[next] }),
-    {}
-  );
+  projectGraphWithOrderedNodes.dependencies = Object.keys(projectGraphWithOrderedNodes.dependencies)
+    .sort((a, b) => a.localeCompare(b))
+    .reduce(
+      (prev, next) => ({
+        ...prev,
+        [next]: projectGraphWithOrderedNodes.dependencies[next],
+      }),
+      {}
+    );
 
   // populate local npm package dependencies
   Object.values(projectGraphWithOrderedNodes.dependencies).forEach((projectDeps) => {