fix: update npm utility dependencies and related packages (lerna#4033)

Author: JamesHenry

.eslintrc.json

@@ -26,6 +26,13 @@
             ],
             "checkDynamicDependenciesExceptions": [".*"]
           }
+        ],
+        "no-restricted-imports": [
+          "error",
+          {
+            "name": "npmlog",
+            "message": "Please use the inlined core utility instead."
+          }
         ]
       }
     },

e2e/publish/src/from-git-recover-from-error.spec.ts

@@ -79,6 +79,7 @@ describe("lerna-publish-from-git-recover-from-error", () => {
         lerna WARN ENOLICENSE Packages test-1 and test-2 are missing a license.
         lerna WARN ENOLICENSE One way to fix this is to add a LICENSE.md file to the root of this repository.
         lerna WARN ENOLICENSE See https://choosealicense.com for additional guidance.
+        lerna WARN publish Package is already published: [email protected]
         lerna success published test-2 XX.XX.XX
         lerna notice
         lerna notice 📦  [email protected]
@@ -96,7 +97,6 @@ describe("lerna-publish-from-git-recover-from-error", () => {
         lerna notice integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
         lerna notice total files:   3
         lerna notice
-        lerna WARN publish Package is already published: [email protected]
         Successfully published:
          - [email protected]
         lerna success published 1 package

jest.preset.js

@@ -4,7 +4,7 @@ const nxPreset = require("@nx/jest/preset").default;
 module.exports = {
   ...nxPreset,
   clearMocks: true,
-  modulePathIgnorePatterns: ["/__fixtures__/"],
+  modulePathIgnorePatterns: ["/__fixtures__/", "<rootDir>/dist/"],
   testEnvironment: "node",
   /* TODO: Update to latest Jest snapshotFormat
    * By default Nx has kept the older style of Jest Snapshot formats

libs/commands/add/src/index.ts

@@ -226,7 +226,7 @@ class AddCommand extends Command {
         Array.from(node.localDependencies.values()).some((resolved) => resolved.type === "directory")
     );
 
-    if (fetchSpec === "latest") {
+    if (fetchSpec === "latest" || fetchSpec === "*") {
       return true;
     }
 

libs/commands/add/src/lib/add-command.spec.ts

@@ -84,9 +84,9 @@ describe("AddCommand", () => {
       expect.objectContaining({
         // an npm-package-arg Result
         name: "tiny-tarball",
-        fetchSpec: "latest",
+        fetchSpec: "*",
         registry: true,
-        type: "tag",
+        type: "range",
       }),
       expect.objectContaining({
         // an npm-conf snapshot

libs/commands/add/src/lib/get-range-to-reference.ts

@@ -15,7 +15,10 @@ module.exports.getRangeToReference = getRangeToReference;
  */
 function getRangeToReference(spec, deps, loc, prefix) {
   const current = deps[spec.name];
-  const resolved = spec.type === "tag" ? `${prefix}${spec.version}` : spec.fetchSpec;
+  const resolved =
+    spec.type === "tag" || (spec.type === "range" && spec.fetchSpec === "*")
+      ? `${prefix}${spec.version}`
+      : spec.fetchSpec;
 
   if (spec.saveRelativeFileSpec) {
     // "version" has been resolved to pkg.location in getPackageVersion()

libs/commands/bootstrap/src/lib/has-dependency-installed.ts

@@ -1,4 +1,4 @@
-import log from "npmlog";
+import { log } from "@lerna/core";
 import Arborist from "@npmcli/arborist";
 import semver from "semver";
 

libs/commands/create/src/index.ts

@@ -132,7 +132,6 @@ class CreateCommand extends Command {
       this.conf.set("silent", true);
     }
 
-    // save read-package-json the trouble
     if (this.binFileName) {
       this.conf.set("bin", {
         [this.binFileName]: `bin/${this.binFileName}`,
@@ -274,10 +273,12 @@ class CreateCommand extends Command {
         return `${savePrefix}${depNode.version}`;
       }
 
-      if (spec.type === "tag" && spec.fetchSpec === "latest") {
-        // resolve the latest version
+      if (
+        (spec.type === "tag" && spec.fetchSpec === "latest") ||
+        (spec.type === "range" && spec.fetchSpec === "*")
+      ) {
+        // resolve the latest version from local external dependency
         if (exts.has(spec.name)) {
-          // from local external dependency
           return exts.get(spec.name);
         }
 

libs/commands/create/src/lib/cat-file.ts

@@ -9,6 +9,6 @@ module.exports.catFile = catFile;
  * @param {string} content
  * @param {string | import('fs-extra').WriteFileOptions} [opts]
  */
-function catFile(baseDir, fileName, content, opts = "utf8") {
+function catFile(baseDir, fileName, content, opts = "utf8" as const) {
   return fs.writeFile(path.join(baseDir, fileName), `${content}\n`, opts);
 }

libs/commands/diff/src/lib/get-last-commit.ts

@@ -1,6 +1,5 @@
-import { ExecOptions } from "@lerna/core";
-import log from "npmlog";
 import * as childProcess from "@lerna/child-process";
+import { ExecOptions, log } from "@lerna/core";
 
 /**
  *