Commit 1bdf602
This fixes the discount_ calculation logic and promotion tax inclusiveness calculation (medusajs#12960)
* This fixes the discount_ calculation logic
* This fixes the adjustment to be handled as a subtotal value in every calculation and applies the tax inclusive logic on the promotion value itself
* Added some testcases and revoked some changes to improve testing output
* Fixed a test case based on feedback
* Corrected promotion/admin test cases
* Corrected cart/store test case
* Improved cart/store test cases for more robust promotion testing considering tax inclusion flags
* Remove unnessary changes as adjustments now automatically are subtotals and therefore the tax inclusive flag does not need to be applied again
* Remove adjustments->is_tax_inclusive usage everywhere
* Migration script to remove is_tax_inclusive in cart line item adjustment
* Forgot to adjust one more testcase
* Corrections based on fPolic feedback
* Refactored PR to consider feedback from oliver
* Added more testcases for promotion in cart
---------
Co-authored-by: Oli Juhl <[email protected]>1 parent 75320e7 commit 1bdf602
File tree
11 files changed
+1076
-119
lines changed- .changeset
- integration-tests/http/__tests__
- cart/store
- promotions/admin
- packages
- core
- types/src/promotion/common
- utils/src/totals
- __tests__
- adjustment
- line-item
- promotion
- shipping-method
- medusa/src/api/store/carts
- modules/promotion/src/utils/compute-actions
11 files changed
+1076
-119
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments