fix(fulfillment): don't cascade shipping option delete to shipping option type (medusajs#13280)

**What**
- don't cascade delete shipping option type when shipping option is deleted since types can be shared between options
- prevent shipping option type deletion if there are options associated with it

Author: fPolic

.changeset/light-cats-lie.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/fulfillment": patch
+"@medusajs/core-flows": patch
+---
+
+fix(core-flows, fulfillment): don't cascade delete shipping option type when shipping option is deleted

packages/core/core-flows/src/shipping-options/workflows/delete-shipping-option-types.ts

@@ -1,4 +1,8 @@
-import { Modules, ShippingOptionTypeWorkflowEvents } from "@medusajs/framework/utils"
+import {
+  MedusaError,
+  Modules,
+  ShippingOptionTypeWorkflowEvents,
+} from "@medusajs/framework/utils"
 import {
   createHook,
   createWorkflow,
@@ -7,9 +11,25 @@ import {
   WorkflowData,
   WorkflowResponse,
 } from "@medusajs/framework/workflows-sdk"
+import { createStep } from "@medusajs/framework/workflows-sdk"
 import { emitEventStep } from "../../common/steps/emit-event"
 import { removeRemoteLinkStep } from "../../common/steps/remove-remote-links"
 import { deleteShippingOptionTypesStep } from "../steps"
+import { useQueryGraphStep } from "../../common"
+
+const validateDeleteShippingOptionTypesStep = createStep(
+  "validate-delete-shipping-option-types",
+  (input: { shippingOptions: { id: string }[] }) => {
+    const shippingOptions = input.shippingOptions
+
+    if (shippingOptions.length > 0) {
+      throw new MedusaError(
+        MedusaError.Types.INVALID_DATA,
+        "Cannot delete shipping option type because some shipping options are using it."
+      )
+    }
+  }
+)
 
 /**
  * The data to delete one or more shipping option types.
@@ -21,7 +41,8 @@ export type DeleteShippingOptionTypesWorkflowInput = {
   ids: string[]
 }
 
-export const deleteShippingOptionTypesWorkflowId = "delete-shipping-option-types"
+export const deleteShippingOptionTypesWorkflowId =
+  "delete-shipping-option-types"
 /**
  * This workflow deletes one or more shipping-option types. It's used by the
  * [Delete Shipping Option Types Admin API Route](TODO HERE).
@@ -48,11 +69,31 @@ export const deleteShippingOptionTypesWorkflowId = "delete-shipping-option-types
 export const deleteShippingOptionTypesWorkflow = createWorkflow(
   deleteShippingOptionTypesWorkflowId,
   (input: WorkflowData<DeleteShippingOptionTypesWorkflowInput>) => {
-    const deletedShippingOptionTypes = deleteShippingOptionTypesStep(input.ids)
-    const shippingOptionTypesDeleted = createHook("shippingOptionTypesDeleted", {
-      ids: input.ids,
+    const shippingOptionsQuery = useQueryGraphStep({
+      entity: "shipping_option",
+      filters: { shipping_option_type_id: input.ids },
+      pagination: { take: 1 },
+      fields: ["id"],
+    }).config({ name: "get-shipping-options" })
+
+    const shippingOptions = transform(
+      { shippingOptionsQuery },
+      ({ shippingOptionsQuery }) =>
+        shippingOptionsQuery.data as { id: string }[]
+    )
+
+    validateDeleteShippingOptionTypesStep({
+      shippingOptions,
     })
 
+    const deletedShippingOptionTypes = deleteShippingOptionTypesStep(input.ids)
+    const shippingOptionTypesDeleted = createHook(
+      "shippingOptionTypesDeleted",
+      {
+        ids: input.ids,
+      }
+    )
+
     const typeIdEvents = transform({ input }, ({ input }) => {
       return input.ids?.map((id) => {
         return { id }

packages/modules/fulfillment/integration-tests/__tests__/fulfillment-module-service/index.spec.ts

@@ -74,7 +74,7 @@ function expectSoftDeleted(
   let shippingOption = serviceZone.shipping_options[0]
   expect(!!shippingOption.deleted_at).toEqual(softDeleted)
   expect(!!shippingOption.shipping_profile.deleted_at).toEqual(false)
-  expect(!!shippingOption.type.deleted_at).toEqual(softDeleted)
+  expect(!!shippingOption.type.deleted_at).toEqual(false) // do not cascade delete shipping option type since it is shared between shipping options
   expect(shippingOption.fulfillments).toHaveLength(1)
   expect(shippingOption.rules).toHaveLength(1)