You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add js-sdk to resolutions in local development section (medusajs#14197)
## Summary
**What** — What changes are introduced in this PR?
*Please provide answer here*
**Why** — Why are these changes relevant or necessary?
*Please provide answer here*
**How** — How have these changes been implemented?
*Please provide answer here*
**Testing** — How have these changes been tested, or how can the reviewer test the feature?
*Please provide answer here*
---
## Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
```ts
// Example usage
```
---
## Checklist
Please ensure the following before requesting a review:
- [ ] I have added a **changeset** for this PR
- Every non-breaking change should be marked as a **patch**
- To add a changeset, run `yarn changeset` and follow the prompts
- [ ] The changes are covered by relevant **tests**
- [ ] I have verified the code works as intended locally
- [ ] I have linked the related issue(s) if applicable
---
## Additional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+7-5Lines changed: 7 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,6 +5,7 @@ Thank you for considering contributing to Medusa! This document will outline how
5
5
If you're contributing to our documentation, make sure to also check out the [contribution guidelines on our documentation website](https://docs.medusajs.com/resources/contribution-guidelines/docs).
6
6
7
7
### Important
8
+
8
9
Our core maintainers prioritize pull requests (PRs) from within our organization. External contributions are regularly triaged, but not at any fixed cadence. It varies depending on how busy the maintainers are. This is applicable to all types of PRs, so we kindly ask for your patience.
9
10
10
11
If you, as a community contributor, wish to work on more extensive features, please reach out to CODEOWNERS instead of directly submitting a PR with all the changes. This approach saves us both time, especially if the PR is not accepted (which will be the case if it does not align with our roadmap), and helps us effectively review and evaluate your contribution if it is accepted.
@@ -26,11 +27,10 @@ If you, as a community contributor, wish to work on more extensive features, ple
> 2.[A local Medusa application for testing](https://docs.medusajs.com/learn/installation).
31
33
32
-
33
-
34
34
The code snippets in this section assume that your forked Medusa project and the test project are sibling directories, and you optionally setup the starter storefront as part of the installation. For example:
35
35
36
36
```
@@ -42,8 +42,7 @@ The code snippets in this section assume that your forked Medusa project and the
42
42
|__ test-project_storefront // (optional) storefront to interact with medusa application
43
43
```
44
44
45
-
46
-
1. Replace the @medusajs/* dependencies and devDependencies in you test project's `package.json` to point to the corresponding local packages in your forked Medusa repository. You will also need to add the medusa packages in the resolutions section of the `package.json`, so that every dependency is resolved locally. For example, assuming your forked Medusa project and the test project are sibling directories:
45
+
1. Replace the @medusajs/\* dependencies and devDependencies in you test project's `package.json` to point to the corresponding local packages in your forked Medusa repository. You will also need to add the medusa packages in the resolutions section of the `package.json`, so that every dependency is resolved locally. For example, assuming your forked Medusa project and the test project are sibling directories:
47
46
48
47
```json
49
48
// test project package.json
@@ -108,6 +107,7 @@ The code snippets in this section assume that your forked Medusa project and the
@@ -157,7 +158,7 @@ Strive towards keeping your commits small and isolated - this helps the reviewer
157
158
158
159
**Base branch**
159
160
160
-
If you wish to patch v1.x your base branch should be `v1.x`.
161
+
If you wish to patch v1.x your base branch should be `v1.x`.
161
162
162
163
If your changes should result in a new version of Medusa, you will need to generate a **changelog**. Follow [this guide](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) on how to generate a changeset.
163
164
@@ -192,5 +193,6 @@ All PRs should include tests for the changes that are included. We have two type
192
193
### Release
193
194
194
195
The Medusa team will regularly create releases from two release branches:
0 commit comments