Skip to content

Commit 16b30e7

Browse files
authored
Remove Eigen3 minimum version requirement in CMake (ZEISS#163)
* Remove Eigen3 minimum version requirement in CMake Previously, CMakeLists.txt required Eigen3 version 3.3 or higher. Now, it will accept any available version of Eigen3 found. * Add --skipApiVersionCheck flag to Azurite startup Prevents API version compatibility issues by disabling version checks when starting the Azurite blob service in CI. This helps ensure tests run smoothly with newer client tools or SDKs.
1 parent 4746709 commit 16b30e7

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/cmake.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ jobs:
138138
# now use the CZIcmd executable to create a test CZI file
139139
"$czicmd" --command CreateCZI --createbounds "C0:2T0:2" --generatorpixeltype Gray8 --compressionopts "zstd1:ExplicitLevel=2;PreProcess=HiLoByteUnpack" --createsubblocksize "1024x1024" -o test --bitmapgenerator default
140140
# start Azurite in the background (we start only the blob-service, as we only need this for the tests)
141-
azurite-blob --inMemoryPersistence --silent &
141+
azurite-blob --inMemoryPersistence --silent --skipApiVersionCheck &
142142
# create a blob container "testcontainer"
143143
az storage container create --name testcontainer --connection-string "$AZURE_BLOB_STORE_CONNECTION_STRING"
144144
# upload the test CZI file to the container

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.15)
33
cmake_policy(SET CMP0091 NEW) # enable new "MSVC runtime library selection" (https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html)
44

55
project(libCZI
6-
VERSION 0.67.3
6+
VERSION 0.67.4
77
HOMEPAGE_URL "https://github.com/ZEISS/libczi"
88
DESCRIPTION "libCZI is an Open Source Cross-Platform C++ library to read and write CZI")
99

Src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ include(utilities)
66
include(CheckCSourceCompiles)
77

88
if (LIBCZI_BUILD_PREFER_EXTERNALPACKAGE_EIGEN3)
9-
find_package (Eigen3 3.3 REQUIRED NO_MODULE)
9+
find_package (Eigen3 REQUIRED NO_MODULE)
1010
else()
1111
include(ExternalEIGEN3)
1212
endif()

docs/source/pages/version_history.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,5 @@ Version history
5151
0.67.0 | [153](https://github.com/ZEISS/libczi/pull/153) | add mask support
5252
0.67.1 | [157](https://github.com/ZEISS/libczi/pull/157) | fix compilation issue on macOS
5353
0.67.2 | [155](https://github.com/ZEISS/libczi/pull/155) | code cleanup
54-
0.67.3 | [158](https://github.com/ZEISS/libczi/pull/158) | have all internal code in its own namespace `libCZI::detail`, update vendored pugixml to version 1.15, fix issue with big-endian-machines
54+
0.67.3 | [158](https://github.com/ZEISS/libczi/pull/158) | have all internal code in its own namespace `libCZI::detail`, update vendored pugixml to version 1.15, fix issue with big-endian-machines
55+
0.67.4 | [158](https://github.com/ZEISS/libczi/pull/159) | remove version requirement for external eigen3 package

0 commit comments

Comments
 (0)