[Counter-Strike: Source DS] Various memory-corruption errors occassionally stopping the game from starting up

[Buggem]

They all happen after the Logging into Steam game server account step.

Error 1: common

Logging into Steam game server account
corrupted double-linked list

Error 2: uncommon

Logging into Steam game server account
malloc(): invalid size (unsorted)

These aren't inherently Box64 errors, but the way they put it it sounds that is very much the case.

I am unsure how to fix them as they are very general. Can somebody reproduce it and confirm it isn't just me?

[Buggem]

About the long 4294967295 is not a 32bits value warning, it definitely is!
Hexadecimal representation is 0xFFFFFFFF, which fits exactly 32-bits

This function seems to be the one failing

box64/src/include/box32.h

Lines 54 to 59 in 555b506

	static inline long_t to_long(long long l) {
	long_t ret = (long_t)l;
	if(l!=ret)
	printf_log(LOG_NONE, "Warning, long %ld is not a 32bits value\n", l);
	return ret;
	}

[Buggem]

Ahh I think I see where it is.

The comparison is failing due to differences between signed and unsigned long, and the cast to int32_t/long_t is taking the upper bit as signed.

I have to confirm this and then I will submit a PR. As for the others, I'm clueless.

[ptitSeb]

The memory error are some bug in box32 certainly. There are still some bugs in box32, and finding them is harder and harder.

As for the long conversion: yes, that's a signed / unsigned issue. But the don't do PR to change to_long. This function is fine and the message correct.
The issue is that some function wrapper signature use a signal long instead of an unsigned (so linstead of L)

[Buggem]

Logging into Steam game server account
[SteamNetworkingSockets] Waited 28.9ms for SteamNetworkingSockets lock [ServiceThread]
[SteamNetworkingSockets] Waited 28.9ms for SteamNetworkingSockets lock [ServiceThread]
[SteamNetworkingSockets] SteamNetworkingSockets lock held for 5.5ms.  (Performance warning.)  ServiceThread,SteamDatagramClientThinker::Think,EnsureDataCenterRoutesValid,ThinkPingProbes
This is usually a symptom of a general performance problem such as thread starvation.
[SteamNetworkingSockets] SteamNetworkingSockets lock held for 5.5ms.  (Performance warning.)  ServiceThread,SteamDatagramClientThinker::Think,EnsureDataCenterRoutesValid,ThinkPingProbes
This is usually a symptom of a general performance problem such as thread starvation.
free(): invalid pointer
[BOX32] NativeBT: /usr/local/bin/box64() [0x3482ff9c]
[BOX32] NativeBT: /usr/local/bin/box64() [0x3486ea58]
[BOX32] NativeBT: linux-vdso.so.1(__kernel_rt_sigreturn+0) [0x7f84a60808]
[BOX32] NativeBT: /lib64/libc.so.6(+0x82a78) [0x7f848f8a78]
[BOX32] NativeBT: /lib64/libc.so.6(raise+0x1c) [0x7f848b0cfc]
[BOX32] NativeBT: /lib64/libc.so.6(abort+0xe8) [0x7f8489d274]
[BOX32] NativeBT: /lib64/libc.so.6(+0x76a68) [0x7f848eca68]
[BOX32] NativeBT: /lib64/libc.so.6(+0x8d028) [0x7f84903028]
[BOX32] NativeBT: /lib64/libc.so.6(+0x8e980) [0x7f84904980]
[BOX32] NativeBT: /lib64/libc.so.6(free+0xc4) [0x7f84907774]
[BOX32] NativeBT: /usr/local/bin/box64() [0x34e25f3c]
[BOX32] NativeBT: [0x1002291e8]
[BOX32] EmulatedBT: box64(free+0) [0x308121a0]
[BOX32] EmulatedBT: ??? [0x50efa7e04467821d]
[BOX32] 4522|SIGABRT @0x7f848f8a78 (???(/lib64/libc.so.6+0x82a78)) (x64pc=0x308121b3/"???", rsp=0x31c2f08c, stack=0x31b30000:0x31c30000 own=0x31b30000 fp=0x44c1dfe0), for accessing 0x3e900001190 (code=-6/prot=0), db=(nil)((nil):(nil)/(nil):(nil)/???:clean, hash:0/0) handler=0x44ceef50
RSP-0x20:0xffffffe800000000 RSP-0x18:0x446780b9ffffffff RSP-0x10:0x50efa7e044b83bfc RSP-0x08:0x44c1dfe050efa7e0
RSP+0x00:0x50efa7e04467821d RSP+0x08:0xffffffff42b6c35c RSP+0x10:0x51048ac044b83bfc RSP+0x18:0x44c1dfe000000018
RAX:0x0000000000000000 RCX:0x00000000000009c8 RDX:0x0000000044c1df00 RBX:0x0000000044b83bfc 
RSP:0x0000000031c2f08c RBP:0x0000000044c1dfe0 RSI:0x0000000050efa7e0 RDI:0x0000000000000000 
 R8:0x0000000000000000  R9:0x0000000000000000 R10:0x0000000000000000 R11:0x0000000000000000 
R12:0x0000000000000000 R13:0x0000000000000000 R14:0x0000000000000000 R15:0x0000000000000000 ES:0x002b CS:0x0023 SS:0x002b DS:0x002b FS:0x0000 GS:0x0033 FSBASE=(nil) GSBASE=0x50e393c0

A new error! Very suspicious they all happen during the "Logging into Steam game server account" process.

[ptitSeb]

Yeah, steam is also unstable. That's still box32 issues that need to be found and fix.