Skip to content

Commit 6eb5a12

Browse files
Merge pull request #176 from pubky/style/qr-scanner
style: qr scanner
2 parents 376f746 + b7d3866 commit 6eb5a12

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ android {
8282
applicationId "to.pubky.ring"
8383
minSdkVersion rootProject.ext.minSdkVersion
8484
targetSdkVersion rootProject.ext.targetSdkVersion
85-
versionCode 10
86-
versionName "1.5"
85+
versionCode 11
86+
versionName "1.6"
8787
}
8888

8989
signingConfigs {

ios/pubkyring.xcodeproj/project.pbxproj

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,14 @@
235235
inputFileListPaths = (
236236
"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-resources-${CONFIGURATION}-input-files.xcfilelist",
237237
);
238+
inputPaths = (
239+
);
238240
name = "[CP] Copy Pods Resources";
239241
outputFileListPaths = (
240242
"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-resources-${CONFIGURATION}-output-files.xcfilelist",
241243
);
244+
outputPaths = (
245+
);
242246
runOnlyForDeploymentPostprocessing = 0;
243247
shellPath = /bin/sh;
244248
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-resources.sh\"\n";
@@ -252,10 +256,14 @@
252256
inputFileListPaths = (
253257
"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-frameworks-${CONFIGURATION}-input-files.xcfilelist",
254258
);
259+
inputPaths = (
260+
);
255261
name = "[CP] Embed Pods Frameworks";
256262
outputFileListPaths = (
257263
"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-frameworks-${CONFIGURATION}-output-files.xcfilelist",
258264
);
265+
outputPaths = (
266+
);
259267
runOnlyForDeploymentPostprocessing = 0;
260268
shellPath = /bin/sh;
261269
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-pubkyring/Pods-pubkyring-frameworks.sh\"\n";
@@ -281,7 +289,7 @@
281289
buildSettings = {
282290
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
283291
CLANG_ENABLE_MODULES = YES;
284-
CURRENT_PROJECT_VERSION = 4;
292+
CURRENT_PROJECT_VERSION = 8;
285293
DEVELOPMENT_TEAM = KYH47R284B;
286294
ENABLE_BITCODE = NO;
287295
INFOPLIST_FILE = pubkyring/Info.plist;
@@ -312,7 +320,7 @@
312320
buildSettings = {
313321
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
314322
CLANG_ENABLE_MODULES = YES;
315-
CURRENT_PROJECT_VERSION = 4;
323+
CURRENT_PROJECT_VERSION = 8;
316324
DEVELOPMENT_TEAM = KYH47R284B;
317325
INFOPLIST_FILE = pubkyring/Info.plist;
318326
INFOPLIST_KEY_CFBundleDisplayName = "Pubky Ring";
@@ -405,10 +413,7 @@
405413
"-DFOLLY_CFG_NO_COROUTINES=1",
406414
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
407415
);
408-
OTHER_LDFLAGS = (
409-
"$(inherited)",
410-
" ",
411-
);
416+
OTHER_LDFLAGS = "$(inherited) ";
412417
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
413418
SDKROOT = iphoneos;
414419
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
@@ -477,10 +482,7 @@
477482
"-DFOLLY_CFG_NO_COROUTINES=1",
478483
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
479484
);
480-
OTHER_LDFLAGS = (
481-
"$(inherited)",
482-
" ",
483-
);
485+
OTHER_LDFLAGS = "$(inherited) ";
484486
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
485487
SDKROOT = iphoneos;
486488
USE_HERMES = true;

src/components/QRScanner.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { memo, useCallback } from 'react';
2-
import { StyleSheet, View } from 'react-native';
2+
import { Platform, StyleSheet, View } from 'react-native';
33
import Camera from './Camera/Camera';
44
import { ActionSheetContainer, Clipboard, Text } from '../theme/components.ts';
55
import { useSelector } from 'react-redux';
@@ -54,7 +54,7 @@ const styles = StyleSheet.create({
5454
width: '100%',
5555
},
5656
cameraContainer: {
57-
height: '81%', // There's quirk on Android where the camera barely appears above the modal if this is 80%
57+
height: '81%',
5858
width: '90%',
5959
alignSelf: 'center'
6060
},
@@ -71,7 +71,10 @@ const styles = StyleSheet.create({
7171
alignItems: 'center',
7272
justifyContent: 'center',
7373
alignContent: 'center',
74-
bottom: 0,
74+
bottom: Platform.select({
75+
ios: 0,
76+
android: 20,
77+
})
7578
},
7679
actionButton2: {
7780
flexDirection: 'row',

0 commit comments

Comments
 (0)