block syntax stops working

[flamingtop]

Hi, I'm using express 3.4.7. Before I imported express-partials, I used blocks to organize my views,

in layout.jade

body
  block content

in index.jade

extends layout
block content
  ....

Results in a blank page only with layout.jade's content rendered but not index.jade's. Does express-partial excludes blocks?

Now I have to use

body
  != body

which seems to work with partials only needed to modify index.jade to

include layout
  ....

The problem is if I put a bit more into the layout, for example

body
  h1 hello
  != body

h1 hello turns out to be rendered twice.

I need partials because I needed to use them dynamically

- partial( /* dynamic view name */ ) 

which through "include" or "block" cant be achieved. Is there a way to get the good stuff from both express 3 and express-partials?

[slaskis]

express-partials was really meant to be used the same way as in express 2.x to ease the gap in the transition. And back then jade didn't even have blocks so it's not really a planned feature.

You can however use a mixin in jade. And include should work as well you just need to expose the variables you need inside the included template. But I'd go with a mixin in that case, it's a little bit cleaner. Unless I totally misunderstood what you mean with dynamically...

[ShawnXu]

Sorry I wasn't clear about "dynamic". I meant doing something like this:

include product/#{product_name}

I've tried to do that before I landed on express-partial, some one on the internet pointed out that "include" is compile time, it doesn't work with "dynamic" paths. As far as I know, there's no way to render a partial with its partial determined at runtime in express 3.x.

[slaskis]

Ah yes, I've actually had this problem with jade too which made me fork it and add that. Unfortunately I don't think I have that fork around anywhere. But it was really hacky anyway.

[flamingtop]

Thanks, I think I can stick with express-partial now. It's a pity express 3 isn't having that. As asked in my original post, can you shed some light on why

body
  h1 hello
  != body

ended up rendering h1 twice?

[slaskis]

No idea, blocks wasn't part of jade back then so it might just not be compatible to use both blocks and partials.

If you could provide a PR with a failing test I can help you debug.

[ShawnXu]

Hi, the cause for the previous issue turns out to be that I used

include layout

in my partial views which isn't necessary. Removing that above line and adjusting the indentation fixed that. So the view system must be implicitly applying layout.jade to any res.render('...') calls.

Thanks.

[ashblue]

I am also getting a double render bug with EJS too. Its causing some chaos when partials are processed. Really need partials, why can't Express just have this natively?