Skip to content

Conversation

@tomootes
Copy link
Contributor

@tomootes tomootes commented Nov 20, 2024

I created this PR for two reasons;

  • I wanted to contribute to this project because i'm involved in the mission to make Open Source more discoverable.
  • I realized, that as soon as you arrive on https://yml.publiccode.tools/, its tough to find the source code and find out if you can contribute. Despite it is actually fairly easy to contribute to this standard.

I added three things in this PR:

Github logo with link to repo in navbar
Screenshot from 2024-11-20 08-50-53

Link to Authors.md in footer + link to Github again
Screenshot from 2024-11-20 08-50-32

Added info to readme.md on how to develop locally
This answers the question immediately, that the website is build on Sphinx.

Concessions
Take note that i had to accept some concessions:

  • The footer doesn't contain credits to Sphinx or the theme anymore. I hope this is acceptable.
  • I had to completely replace the HTML of the navbar using a template. All functionality works still, but its what i had to do to be able to add the Github icon.

@bfabio
Copy link
Contributor

bfabio commented Nov 20, 2024

Thanks @tomootes! Reviewing ASAP

@bfabio bfabio self-requested a review November 20, 2024 15:28
@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
publiccode-yml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 1:05pm

@tomootes
Copy link
Contributor Author

@ruphy. Thanks for the suggestion, I accepted it

Copy link
Member

@sebbalex sebbalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomootes, I just pointing out a couple of catches

@tomootes
Copy link
Contributor Author

Oioi, quite some mistakes in a small PR. Note to self: check it again in the morning :)

Should i rebase the branch? This cleans the commit history but wipes all proposed changes/ commits.

Are you guys happy with it?

@bfabio
Copy link
Contributor

bfabio commented Nov 25, 2024

@tomootes i changed i couple of things in the development section and moved it. It looks good to me.

Let me know your take on the copyright thing and after that it's good to merge!

@tomootes
Copy link
Contributor Author

Copyright thingy is fine! @bfabio lets merge 👍

@bfabio bfabio merged commit 4efeaf5 into publiccodeyml:main Nov 26, 2024
1 check passed
@ruphy
Copy link
Member

ruphy commented Nov 26, 2024

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants