Bump python version #249
Bump python version #249
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Is it not a UK vs US thing? |
Yes but still I think it's way more common to see "license" around, WDYT? |
|
Like:
|
.github/workflows/bot.yml
Outdated
| jobs: | ||
| bot: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
I don't know about this. ubuntu-latest is always expected to be just a runner capable of running the actions we have, and the actual environment is defined by the actions themselves.
Not a big deal to update every couple years, but still a manual thing to do.
There was a problem hiding this comment.
Yup, makes sense, we have a strict policy on dependency pinning (also on runners) but we can revert to -latest if that comes more handy
There was a problem hiding this comment.
Yes please. If someone compromises GH's ubuntu-latest they deserve to publish freely on the site. ;)
I agree it looks bad, I'm trying to force myself to use the UK spelling because the project was set up that way, but sometimes it's just hard. |
|
@libremente thanks! If you could squash the reverted commits, we're good to go. |
libremente
force-pushed
the
bump-min-python-version
branch
from
210b9f6 to
d5a5278
Compare
|
There you go, thanks @bfabio |
This PR:
imghdris deprecated and it is removed starting 3.13 (so the build with the current requirements fails on 3.13). To solve this I think It's probably better to move to a later version of Sphinx if/when necessary;pins ubuntu to the latest available LTS (24.04) in the workflows;Oh, I like to say licen
sed way more than licenced, in the same way that I like licenSe more than licenCe but I guess that's just personal taste?Fixes #243