Autocorrect new autocorrectable RuboCop offenses

Author: mvz

app/models/article.rb

@@ -101,7 +101,7 @@ def self.last_draft(article_id)
 
   def self.search_with(params)
     params ||= {}
-    scoped = super(params)
+    scoped = super
     if %w(no_draft drafts published withdrawn pending).include?(params[:state])
       scoped = scoped.send(params[:state])
     end
@@ -145,7 +145,7 @@ def next
   end
 
   def previous
-    Article.where("published_at < ?", published_at).order("published_at desc")
+    Article.where(published_at: ...published_at).order("published_at desc")
       .limit(1).first
   end
 

app/models/config_manager.rb

@@ -69,9 +69,7 @@ def canonicalize(key, value)
     self.class.fields[key.to_s].canonicalize(value)
   end
 
-  def settings_keys
-    self.class.settings_keys
-  end
+  delegate :settings_keys, to: :class
 
   class Item
     VALID_TYPES = [:boolean, :integer, :string, :text].freeze

app/models/note.rb

@@ -21,7 +21,7 @@ class Note < Content
   after_create :set_permalink, :shorten_url
 
   scope :published, lambda {
-    where(state: "published").where("published_at <= ?", Time.zone.now).order(default_order)
+    where(state: "published").where(published_at: ..Time.zone.now).order(default_order)
   }
   default_scope { order("published_at DESC") }
 

app/models/sidebar.rb

@@ -97,9 +97,7 @@ def html_id
 
   def parse_request(_contents, _params); end
 
-  def fields
-    self.class.fields
-  end
+  delegate :fields, to: :class
 
   def fieldmap(field = nil)
     if field
@@ -109,17 +107,11 @@ def fieldmap(field = nil)
     end
   end
 
-  def description
-    self.class.description
-  end
+  delegate :description, to: :class
 
-  def short_name
-    self.class.short_name
-  end
+  delegate :short_name, to: :class
 
-  def display_name
-    self.class.display_name
-  end
+  delegate :display_name, to: :class
 
   def content_partial
     "/#{self.class.path_name}/content"

app/models/trigger.rb

@@ -11,7 +11,7 @@ def post_action(due_at, item, method = "came_due")
     end
 
     def fire
-      where("due_at <= ?", Time.zone.now).destroy_all
+      where(due_at: ..Time.zone.now).destroy_all
       true
     end
 

spec/controllers/articles_controller_spec.rb

@@ -196,7 +196,7 @@
       end
 
       it "assigns @search the search string" do
-        expect(assigns[:search]).to be_equal(controller.params[:q])
+        expect(assigns[:search]).to equal(controller.params[:q])
       end
     end
   end