Add initial support for windows (#34)

Author: pcj

README.md

@@ -20,6 +20,11 @@
 | [node_binary](#node_binary) | Build a node_modules tree and execute an entrypoint module script. |
 | [mocha_test](#mocha_test) |  Run a mocha test script. |
 
+<table><tr>
+<td><img src="https://www.kernel.org/theme/images/logos/tux.png" height="48"/></td>
+<td><img src="https://upload.wikimedia.org/wikipedia/commons/f/fa/Apple_logo_black.svg" height="48"/></td>
+<td><img src="https://upload.wikimedia.org/wikipedia/commons/5/5f/Windows_logo_-_2012.svg" height="48"/></td>
+</tr></table>
 
 ## node_repositories
 

node/internal/node_binary.bzl

@@ -67,15 +67,15 @@ def _create_launcher(ctx, output_dir, node):
         'cd $ROOT/%s' % output_dir,
         '&&',
         'exec',
-        'node',
+        ctx.executable._node.basename,
     ] + ctx.attr.node_args + [
         entrypoint,
     ] + ctx.attr.script_args + [
         '$@',
     ]
 
     lines = [
-        '#!/usr/bin/env bash',
+        '#!/usr/bin/env bash', # TODO(user): fix for windows
         'set -e',
 
         # Set the execution root to the same directory where the
@@ -87,6 +87,7 @@ def _create_launcher(ctx, output_dir, node):
 
         # Resolve to this node instance if other scripts have
         # '/usr/bin/env node' shebangs
+        # TODO: fix for windows
         'export PATH="$ROOT:$PATH"',
 
         ' '.join(cmd)
@@ -120,7 +121,7 @@ def node_binary_impl(ctx):
         content = manifest_content.to_json(),
     )
 
-    node = ctx.new_file('%s/node' % output_dir)
+    node = ctx.new_file('%s/%s' % (output_dir, ctx.executable._node.basename))
     ctx.action(
         mnemonic = 'CopyNode',
         inputs = [ctx.executable._node],

node/internal/node_repositories.bzl

@@ -95,7 +95,7 @@ _node_repository = repository_rule(
       default = "d67d2eb9456aab925416ad58aa18b9680e66a4bcc243a89b22e646f7fffc4ff9",
     ),
     "windows_sha256": attr.string(
-      default = "a03512d8f17d8312c6fece68a9c20aaa8e2268de18edfea847aa6a35af3a95ba",
+      default = "617590f06f9a0266ceecb3fd17120fc2fbf8669980974f339a83f3b56ed05f7b",
     ),
   },
 )

node/internal/yarn_modules.bzl

@@ -36,7 +36,11 @@ def _yarn_modules_impl(ctx):
         fail("You must specify a package.json file OR deps (not both!)")
 
     # Gather required resources
-    node = ctx.path(ctx.attr._node)
+    node_label = ctx.attr._node
+    if ctx.os.name.lower().find("windows") != -1:
+        node_label = ctx.attr._node_exe
+    node = ctx.path(node_label)
+
     parse_yarn_lock_js = ctx.path(ctx.attr._parse_yarn_lock_js)
     yarn_js = ctx.path(ctx.attr._yarn_js)
 
@@ -79,6 +83,13 @@ yarn_modules = repository_rule(
             executable = True,
             cfg = "host",
         ),
+        "_node_exe": attr.label(
+            default = Label("@node//:node.exe"),
+            single_file = True,
+            allow_files = True,
+            executable = True,
+            cfg = "host",
+        ),
         "_parse_yarn_lock_js": attr.label(
             default = Label("//node:internal/parse_yarn_lock.js"),
             single_file = True,