Skip to content

Commit b64ea37

Browse files
committed
Merge branch 'master' of github.com:pubref/rules_node
2 parents f6a3178 + c63bbcc commit b64ea37

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ os:
88
- osx
99

1010
env:
11-
- V=HEAD
11+
- V=0.4.3
12+
- V=0.4.2
13+
- V=0.4.1
1214
- V=0.4.0
1315
- V=0.3.2
1416
- V=0.3.1

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ you can determine this). By setting a `sha256`, you can guard against
8080
the code changing, but you are not guarding against a malicious
8181
attacker sneaking in bogus code in the first place.
8282

83+
> Note: the `WORKSPACE` for `rules_node` itself is not yet using the
84+
> sha256 option as there seems to be remaining non-determinism that
85+
> renders it flaky.
86+
8387
#### What gets removed before determining the sha256?
8488

8589
In order to make npm deterministic it is necessary to:

WORKSPACE

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,37 +17,37 @@ npm_repository(
1717
"react": "15.3.2",
1818
"react-dom": "15.3.2",
1919
},
20-
sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0",
20+
#sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0",
2121
)
2222

2323
npm_repository(
2424
name = "npm_mocha",
2525
deps = {
2626
"mocha": "3.1.0",
2727
},
28-
sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8",
28+
#sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8",
2929
)
3030

3131
npm_repository(
3232
name = "npm_underscore",
3333
deps = {
3434
"underscore": "1.8.3",
3535
},
36-
sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8",
36+
#sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8",
3737
)
3838

3939
npm_repository(
4040
name = "npm_bower",
4141
deps = {
4242
"bower": "1.7.9",
4343
},
44-
sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f",
44+
#sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f",
4545
)
4646

4747
bower_repository(
4848
name = "bower_react_stack",
4949
deps = {
5050
"react": "15.3.2",
5151
},
52-
sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845",
52+
#sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845",
5353
)

0 commit comments

Comments
 (0)