Skip to content

Commit b8c31c8

Browse files
committed
Update readme and drop 0.3.0 from build matrix.
1 parent 671acca commit b8c31c8

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ language: node_js
55
env:
66
- V=HEAD URL=http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=linux-x86_64/lastSuccessfulBuild/artifact/output/ci/bazel--installer.sh FLAGS='--worker_verbose --strategy=Javac=worker --strategy=JsChecker=worker'
77
- V=0.3.1 URL=https://github.com/bazelbuild/bazel/releases/download/0.3.1/bazel-0.3.1-installer-linux-x86_64.sh FLAGS=''
8-
- V=0.3.0 URL=https://github.com/bazelbuild/bazel/releases/download/0.3.0/bazel-0.3.0-installer-linux-x86_64.sh FLAGS=''
98

109
before_install:
1110
- wget -O install.sh $URL

README.md

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
# Installation
44

5-
load `rules_node` in your `WORKSPACE` and load main repository
6-
dependencies:
5+
Put `rules_node` in your `WORKSPACE` and load the main repository
6+
dependencies. This will download the nodejs toolchain including
7+
`node` and `npm`.
78

89
```python
910
git_repository(
@@ -14,13 +15,13 @@ git_repository(
1415

1516
load("@org_pubref_rules_node//node:rules.bzl", "node_repositories")
1617

17-
node_repositories() # installs node toolchain incl. 'node' and 'npm'
18+
node_repositories()
1819
```
1920

2021
# Rules
2122

2223
| Rule | Description |
23-
| :--- | ---: | :---------- |
24+
| ---: | :---------- |
2425
| [node_repositories](#node_repositories) | Install node toolchain. |
2526
| [npm_library](#npm_library) | Declare an npm dependency. |
2627
| [node_binary](#node_binary) | Build or execute a nodejs script. |
@@ -49,11 +50,11 @@ node_binary(
4950
)
5051
```
5152

52-
## node_\repositories
53+
## node_repositories
5354

5455
WORKSPACE rule. No current options.
5556

56-
## npm_\library
57+
## npm_library
5758

5859
BUILD rule. Declares a set of npm dependencies. Functionally
5960
equivalent to `npm install --global` (global being relative to the npm
@@ -66,7 +67,14 @@ Takes two forms:
6667
1. **Multiple import**: uses a string_dict declaring the
6768
`name@version` dependency. (see `react-stack` above).
6869

69-
## node_\binary
70+
## node_binary
7071

7172
BUILD rule. Create an executable script that will run the file named
7273
in the `main_script` attribute.
74+
75+
76+
> **WARNING**: these rules are not hermetic or secure! It trusts that
77+
> the `npm install` command does what is it supposed to do. There is
78+
> no current support for valdating that a particular npm package(s)
79+
> matches a sha256 (this is the the norm for npm, but it is
80+
> sub-standard for bazel).

0 commit comments

Comments
 (0)