Adds --nodedir option for better node-gyp interoperability.

- Removes unused old rule node_repository.

Author: pcj

README.md

@@ -127,7 +127,6 @@ node_library(
     srcs = [
         "qux.js",
     ],
-    use_prefix = False,
 )
 ```
 

node/internal/node_binary.bzl

@@ -39,8 +39,9 @@ def _get_node_modules_dir_from_sourcefile(file):
 def node_binary_impl(ctx):
     inputs = []
     srcs = []
-    node_paths = []
     script = ctx.file.main
+    node = ctx.file._node
+    node_paths = []
 
     for file in ctx.files.modules:
         if not file.basename.endswith("node_modules"):
@@ -55,7 +56,6 @@ def node_binary_impl(ctx):
         node_paths += [_get_node_modules_dir_from_package_json(lib.package_json)]
 
     node_paths = list(set(node_paths))
-    node = ctx.file._node
 
     ctx.file_action(
         output = ctx.outputs.executable,

node/internal/node_repositories.bzl

@@ -1,5 +1,3 @@
-load("//node:internal/node_repository.bzl", "node_repository")
-
 NODE_TOOLCHAIN_BUILD_FILE = """
 package(default_visibility = [ "//visibility:public" ])
 exports_files([

node/internal/node_repository.bzl

@@ -10,7 +10,7 @@ def _execute(ctx, cmds):
     result = ctx.execute(cmds)
     if result.return_code:
         fail(" ".join(cmds) + "failed: %s" %(result.stderr))
-    return result.stdout
+    return result
 
 
 def _dnode_modules(ctx, node_modules_path):
@@ -30,8 +30,7 @@ def _dnode_modules(ctx, node_modules_path):
         cmd.append("--exclude")
         cmd += ctx.attr.exclude_package_json_keys
 
-    output = _execute(ctx, cmd)
-    print(output)
+    output = _execute(ctx, cmd).stdout
 
 
 def _check_sha256(ctx, node_modules_path):
@@ -66,16 +65,17 @@ def _check_sha256(ctx, node_modules_path):
     ])
 
     expected = ctx.attr.sha256
-    actual = _execute(ctx, sha256 + [tarfile]).split(" ")[0]
+    actual = _execute(ctx, sha256 + [tarfile]).stdout.split(" ")[0]
     if actual != expected:
         fail(ctx.name + " node_modules archive sha256 [%s] does not match expected value [%s]" %(actual, expected))
 
+    ctx.file("node_modules.sha256", actual)
 
 def _npm_repository_impl(ctx):
     node = ctx.path(ctx.attr.node)
+    nodedir = node.dirname.dirname
     npm = ctx.path(ctx.attr.npm)
     node_modules_path = ctx.attr.node_modules_path
-
     modules = []
     for k, v in ctx.attr.deps.items():
         if v:
@@ -87,7 +87,9 @@ def _npm_repository_impl(ctx):
         node,
         npm,
         "install",
+        #"--loglevel", "silly", # info
         "--prefix", ctx.path(""),
+        "--nodedir=%s" % nodedir,
         "--global"
     ]
 
@@ -96,7 +98,8 @@ def _npm_repository_impl(ctx):
 
     cmd += modules
 
-    _execute(ctx, cmd)
+    output = _execute(ctx, cmd).stdout
+    #print("npm install output: %s" % output)
 
     if ctx.attr.sha256:
         _dnode_modules(ctx, node_modules_path)