share() method has depreciated in Laravel 5.4 (#24)

ebisbe · pulkitjalan · commit ea8b9deabd0d · 2017-01-26T07:54:08.000Z
* deprecated function share() use singleton() instead
diff --git a/.gitignore b/.gitignore
@@ -2,3 +2,4 @@
 composer.lock
 .DS_Store
 /build
+.idea
diff --git a/src/GeoIPServiceProvider.php b/src/GeoIPServiceProvider.php
@@ -51,7 +51,7 @@ public function register()
      */
     protected function registerGeoIP()
     {
-        $this->app['geoip'] = $this->app->share(function ($app) {
+        $this->app->singleton('geoip', function() {
             return new GeoIP(config('geoip'));
         });
     }
@@ -63,7 +63,7 @@ protected function registerGeoIP()
      */
     protected function registerUpdateCommand()
     {
-        $this->app['command.geoip.update'] = $this->app->share(function ($app) {
+        $this->app->singleton('geoip', function() {
             return new UpdateCommand(config('geoip'));
         });
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function register()`
`51`	`51`	`*/`
`52`	`52`	`protected function registerGeoIP()`
`53`	`53`	`{`
`54`		`- $this->app['geoip'] = $this->app->share(function ($app) {`
	`54`	`+ $this->app->singleton('geoip', function() {`
`55`	`55`	`return new GeoIP(config('geoip'));`
`56`	`56`	`});`
`57`	`57`	`}`
`@@ -63,7 +63,7 @@ protected function registerGeoIP()`
`63`	`63`	`*/`
`64`	`64`	`protected function registerUpdateCommand()`
`65`	`65`	`{`
`66`		`- $this->app['command.geoip.update'] = $this->app->share(function ($app) {`
	`66`	`+ $this->app->singleton('geoip', function() {`
`67`	`67`	`return new UpdateCommand(config('geoip'));`
`68`	`68`	`});`
`69`	`69`