better test coverage

Author: dominictarr

test/index.js

@@ -9,23 +9,25 @@ test('read this file', function (t) {
   var lines = file.split('\n')
   var i = 0, block = 300
 
-  pull.pipeableSource(function () {
-    return function (end, cb) {
+  pull(
+    function (end, cb) {
       if (i > file.length)
         cb(true)
       else {
         var _i = i
         i += block
         cb(null, file.substring(_i, _i + block))
       }
-    }
-  })()
-  .pipe(split())
-  .pipe(pull.writeArray(function (err, array){
-    t.equal(array.length, lines.length)
-    t.deepEqual(array, lines)
-    t.end()
-  }))
+    },
+    split(),
+    pull.collect(function (err, array){
+      t.equal(array.length, lines.length)
+      t.deepEqual(array, lines)
+      t.end()
+    })
+  )
 })
 
 //haoeunhoeu
+
+

test/json.js

@@ -0,0 +1,56 @@
+var tape = require('tape')
+var pull = require('pull-stream')
+var Split = require('../')
+
+var input = [
+  1, 2, {okay: true}, 'whatever'
+]
+
+
+tape('split into json lines', function (t) {
+
+  pull(
+    pull.values([input.map(JSON.stringify).join('\n')]
+),
+    Split(null, JSON.parse),
+    pull.collect(function (err, ary) {
+      if(err) throw err
+      t.deepEqual(ary, input)
+      t.end()
+    })
+  )
+
+})
+
+tape('split into json lines', function (t) {
+
+  pull(
+    pull.values([input.map(function (d) {
+      return JSON.stringify(d, null, 2)
+    }).join('\n\n')]
+),
+    Split('\n\n', JSON.parse),
+    pull.collect(function (err, ary) {
+      if(err) throw err
+      t.deepEqual(ary, input)
+      t.end()
+    })
+  )
+})
+
+
+tape('split into json lines', function (t) {
+
+  pull(
+    pull.values([input.map(function (d) {
+      return JSON.stringify(d, null, 2) + '\n'
+    }).join('\n')]
+),
+    Split('\n\n', JSON.parse),
+    pull.collect(function (err, ary) {
+      if(err) throw err
+      t.deepEqual(ary, input)
+      t.end()
+    })
+  )
+})

test/reverse.js

@@ -9,8 +9,8 @@ test('read this file', function (t) {
   var lines = file.split('\n').reverse()
   var i = file.length, block = 300
 
-  pull.pipeableSource(function () {
-    return function (end, cb) {
+  pull(
+    function (end, cb) {
       if (i <= 0)
         cb(true)
       else {
@@ -20,14 +20,16 @@ test('read this file', function (t) {
         var line = file.substring(_i - block, _i)
         cb(null, line)
       }
-    }
-  })()
-  .pipe(split('\n', null, true))
-  .pipe(pull.writeArray(function (err, array){
-    t.equal(array.length, lines.length)
-    t.deepEqual(array, lines)
-    t.end()
-  }))
+    },
+    split('\n', null, true),
+    pull.collect(function (err, array){
+      t.equal(array.length, lines.length)
+      t.deepEqual(array, lines)
+      t.end()
+    })
+  )
 })
 
 //haoeunhoeu
+
+

test/skip-last.js

@@ -0,0 +1,34 @@
+var test = require('tape')
+var pull = require('pull-stream')
+var split = require('../')
+
+test('read this file', function (t) {
+
+  var fs = require('fs')
+  var file = fs.readFileSync(__filename).toString()
+  var lines = file.split('\n')
+  t.equal(lines.pop(), '')
+  var i = 0, block = 300
+
+  pull(
+    function (end, cb) {
+      if (i > file.length)
+        cb(true)
+      else {
+        var _i = i
+        i += block
+        cb(null, file.substring(_i, _i + block))
+      }
+    },
+    split(null, null, null, true),
+    pull.collect(function (err, array){
+      t.equal(array.length, lines.length)
+      t.deepEqual(array, lines)
+      t.end()
+    })
+  )
+})
+
+//haoeunhoeu
+
+