Skip to content

Commit 64d198a

Browse files
committed
Implement CodeRabit Feedback
1 parent 02b6b65 commit 64d198a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Deeploy/Targets/PULPOpen/Parsers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ def parseNode(self, node: gs.Node) -> bool:
355355

356356
M = node.inputs[0].shape[-1 if node.attrs["transA"] else -2]
357357
batch = math.prod(node.inputs[0].shape[:-2])
358-
return super().parseNode(node) and M == 1 and batch >= 8
358+
return M == 1 and batch >= 8
359359

360360

361361
class PULPTallGEMMParser(PULPGEMMParser):
@@ -367,4 +367,4 @@ def parseNode(self, node: gs.Node) -> bool:
367367
M = node.inputs[0].shape[-1 if node.attrs["transA"] else -2]
368368
N = node.inputs[1].shape[-2 if node.attrs["transB"] else -1]
369369
batch = math.prod(node.inputs[0].shape[:-2])
370-
return super().parseNode(node) and M >= 8 and (M % 8) < (N % 8) and batch < 8
370+
return M >= 8 and (M % 8) < (N % 8) and batch < 8

Deeploy/Targets/Snitch/Layers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def computeOps(self):
1818
return self.mapper.parser.operatorRepresentation['size'] * 4 # 2 mul, 1 add, 1 right shift
1919

2020
def computeShapes(self, inputShapes: Shape, outputShapes: Shape, operatorRepresentation: OperatorRepresentation,
21-
channels_first: bool) -> Tuple[Shape]:
21+
channels_first: bool) -> Tuple[Shape, Shape]:
2222
# JUNGVI: Broadcast the weights and bias to have as many dimensions as the inputs
2323
shape = np.broadcast_shapes(*inputShapes)
2424
return ([shape] * len(inputShapes), outputShapes)

0 commit comments

Comments
 (0)