Skip to content

Commit 8bca8c8

Browse files
committed
hw: use named default indices
1 parent b9f0045 commit 8bca8c8

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

rtl/croc_domain.sv

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -335,14 +335,16 @@ module croc_domain import croc_pkg::*; #(
335335
.rst_ni,
336336
.testmode_i,
337337

338-
.sbr_ports_req_i ( {core_instr_obi_req, core_data_obi_req, dbg_req_obi_req, user_mgr_obi_req_i } ), // from managers towards subordinates
338+
// connections between managers and crossbar
339+
.sbr_ports_req_i ( {core_instr_obi_req, core_data_obi_req, dbg_req_obi_req, user_mgr_obi_req_i } ),
339340
.sbr_ports_rsp_o ( {core_instr_obi_rsp, core_data_obi_rsp, dbg_req_obi_rsp, user_mgr_obi_rsp_o } ),
340-
.mgr_ports_req_o ( all_sbr_obi_req ), // connections to subordinates
341+
// connections between crossbar and subordinates
342+
.mgr_ports_req_o ( all_sbr_obi_req ),
341343
.mgr_ports_rsp_i ( all_sbr_obi_rsp ),
342344

343-
.addr_map_i ( croc_addr_map ),
344-
.en_default_idx_i ( 4'b1111 ),
345-
.default_idx_i ( '0 )
345+
.addr_map_i ( croc_addr_map ),
346+
.en_default_idx_i ( '1 ),
347+
.default_idx_i ( XbarError )
346348
);
347349

348350
// -----------------
@@ -435,13 +437,13 @@ module croc_domain import croc_pkg::*; #(
435437
.rule_t ( addr_map_rule_t ),
436438
.Napot ( 1'b0 )
437439
) i_addr_decode_periphs (
438-
.addr_i ( xbar_periph_obi_req.a.addr ),
439-
.addr_map_i ( periph_addr_map ),
440-
.idx_o ( periph_idx ),
441-
.dec_valid_o (),
442-
.dec_error_o (),
443-
.en_default_idx_i ( 1'b1 ),
444-
.default_idx_i ( '0 )
440+
.addr_i ( xbar_periph_obi_req.a.addr ),
441+
.addr_map_i ( periph_addr_map ),
442+
.idx_o ( periph_idx ),
443+
.dec_valid_o ( ),
444+
.dec_error_o ( ),
445+
.en_default_idx_i ( 1'b1 ),
446+
.default_idx_i ( PeriphError )
445447
);
446448

447449
obi_demux #(

rtl/user_domain.sv

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ module user_domain import user_pkg::*; import croc_pkg::*; #(
7272
.addr_i ( user_sbr_obi_req_i.a.addr ),
7373
.addr_map_i ( user_addr_map ),
7474
.idx_o ( user_idx ),
75-
.dec_valid_o (),
76-
.dec_error_o (),
77-
.en_default_idx_i ( 1'b1 ),
78-
.default_idx_i ( '0 )
75+
.dec_valid_o ( ),
76+
.dec_error_o ( ),
77+
.en_default_idx_i ( 1'b1 ),
78+
.default_idx_i ( UserError )
7979
);
8080

8181
obi_demux #(

0 commit comments

Comments
 (0)