Skip to content

Commit b6bef95

Browse files
committed
Tidy README and fix image push complaint in CI
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
1 parent b4358f9 commit b6bef95

File tree

2 files changed

+31
-18
lines changed

2 files changed

+31
-18
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,15 @@ on:
88
workflow_dispatch:
99

1010
jobs:
11+
12+
prepare_image:
13+
- name: Pre-build dev container image
14+
uses: devcontainers/ci@v0.3
15+
with:
16+
imageName: ghcr.io/G-Research/pulp-manager-devcontainer
17+
cacheFrom: ghcr.io/G-Research/pulp-manager-devcontainer
18+
push: always
19+
1120
lint:
1221
name: Lint
1322
runs-on: ubuntu-latest
@@ -21,6 +30,8 @@ jobs:
2130
- name: Run lint in devcontainer
2231
uses: devcontainers/ci@v0.3
2332
with:
33+
cacheFrom: ghcr.io/G-Research/pulp-manager-devcontainer
34+
push: never
2435
runCmd: |
2536
cd /workspace
2637
python -m venv venv
@@ -41,6 +52,8 @@ jobs:
4152
- name: Run tests with coverage in devcontainer
4253
uses: devcontainers/ci@v0.3
4354
with:
55+
cacheFrom: ghcr.io/G-Research/pulp-manager-devcontainer
56+
push: never
4457
runCmd: |
4558
cd /workspace
4659
python -m venv venv

README.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
# Pulp Manager
22

33
The Pulp Manager application is used to coordinate common Pulp
4-
workflows and provide some additional reporting capabilities about a
4+
workflows and provide additional reporting capabilities about a
55
cluster of Pulp servers. It is designed to work with Pulp3.
66

7-
We recommend that pulp is operated in a primary/secondary setup. There is a
8-
single pulp instance known as the Pulp Primary which syncs repos from
9-
the Internet and also has custom internal rpms/debs uploaded. Slaves
10-
are then configured to sync these snapshots and internal repos.
7+
We recommend that Pulp be operated in a primary/secondary setup. There
8+
is a single Pulp instance known internally as the Pulp Master which
9+
syncs repos from the Internet and can also have custom or internal
10+
packages uploaded to it. Secondaries are then configured to sync these
11+
snapshots and internal repos.
1112

1213
Pulp3 doesn't provide a method to schedule the synchronisation of
13-
repos, and in some repository types (deb) require multiple steps to
14-
sync and update a repos content. The idea is that Pulp Manager
15-
provides the coordination and reporting for this (along with other
16-
workflows), rather than shoe horning jobs into Jenkins.
17-
18-
Async SQLAlchemy isn't used, which also means most of the API isn't
19-
async. The main reason for this being is the main work of the
20-
application will be done by RQ workers which handles one job at one
21-
time. An RQ worker runs as a single process (although it does use fork
22-
internally), however this still means there is nothing gained from
23-
awaiting on the Database, also other libs such as the hashicorp vault
24-
library are not async. Also this API isn't going to be one that sees
25-
lots of heavy traffic so doesn't gain any real benefit from async
14+
repos, and in some repository types (deb) may require multiple steps
15+
to sync and update a repo's content. Pulp Manager provides the
16+
coordination and reporting for this (along with other workflows),
17+
rather than using a more generic management approach such as Ansible
18+
orJenkins.
19+
20+
APIs are synchronous but usualy launch background jobs for
21+
long-running processes. The main work of the application is done by RQ
22+
workers. An RQ worker runs as a single process (although it does use
23+
fork internally), however this still means there is nothing gained
24+
from awaiting on the Database. Other libs such as the Hashicorp
25+
Vault library are likewise not async.
2626

2727
## Architecture
2828

0 commit comments

Comments
 (0)