Merge pull request #29 from ATIX-AG/optimize_sync

Add --optimize/--no-optimize option for syncs

Author: quba42

CHANGES/31.feature

@@ -0,0 +1 @@
+Added support for the new --optimize/--no-optimize sync option.

pulpcore/cli/deb/repository.py

@@ -18,6 +18,7 @@
     label_select_option,
     list_command,
     name_option,
+    pulp_option,
     repository_href_option,
     repository_option,
     resource_option,
@@ -97,11 +98,22 @@ def repository(ctx: click.Context, pulp_ctx: PulpContext, repo_type: str) -> Non
         "during sync. When disabled, the sync is purely additive."
     ),
 )
+@pulp_option(
+    "--optimize/--no-optimize",
+    default=None,
+    help=(
+        "Using optimize sync, will skip the processing of metadata if the checksum has not changed "
+        "since the last sync. This greately improves re-sync performance in such cases. Disable if "
+        "the sync result does not match expectations."
+    ),
+    needs_plugins=[PluginRequirement("deb", min="2.20.0.dev")],
+)
 @pass_repository_context
 def sync(
     repository_ctx: PulpRepositoryContext,
     remote: EntityFieldDefinition,
     mirror: Optional[bool],
+    optimize: Optional[bool],
 ) -> None:
     repository = repository_ctx.entity
     repository_href = repository_ctx.pulp_href
@@ -111,6 +123,9 @@ def sync(
     if mirror is not None:
         body["mirror"] = mirror
 
+    if optimize is not None:
+        body["optimize"] = optimize
+
     if isinstance(remote, PulpEntityContext):
         body["remote"] = remote.pulp_href
     elif repository["remote"] is None:

tests/scripts/pulp_deb/test_deb_sync_publish.sh

@@ -25,12 +25,22 @@ expect_succ pulp deb remote create \
   --distribution "$DEB_DISTRIBUTION"
 
 expect_succ pulp deb repository create \
-  --name "${ENTITIES_NAME}_repo"
-
-expect_succ pulp deb repository sync \
   --name "${ENTITIES_NAME}_repo" \
   --remote "${ENTITIES_NAME}_remote"
 
+expect_succ pulp deb repository sync \
+  --name "${ENTITIES_NAME}_repo"
+
+if pulp debug has-plugin --name deb --min-version 2.20.0.dev; then
+  expect_succ pulp deb repository sync \
+    --name "${ENTITIES_NAME}_repo" \
+    --optimize
+
+  expect_succ pulp deb repository sync \
+    --name "${ENTITIES_NAME}_repo" \
+    --no-optimize
+fi
+
 expect_succ pulp deb publication create \
   --repository "${ENTITIES_NAME}_repo" \
   --simple "True"