Enforce oauth in oauth test scenario

Author: mdellweg

.ci/settings/settings.py

@@ -4,30 +4,33 @@
 ANALYTICS = False
 ALLOWED_CONTENT_CHECKSUMS = ["sha1", "sha256", "sha512"]
 
-if os.environ.get("PULP_HTTPS", "false").lower() == "true":
+pulp_https = os.environ.get("PULP_HTTPS", "false").lower() == "true"
+pulp_oauth2 = os.environ.get("PULP_OAUTH2", "false").lower() == "true"
+
+if pulp_https and not pulp_oauth2:
     AUTHENTICATION_BACKENDS = "@merge django.contrib.auth.backends.RemoteUserBackend"
     MIDDLEWARE = "@merge django.contrib.auth.middleware.RemoteUserMiddleware"
     REST_FRAMEWORK__DEFAULT_AUTHENTICATION_CLASSES = (
         "@merge pulpcore.app.authentication.PulpRemoteUserAuthentication"
     )
     REMOTE_USER_ENVIRON_NAME = "HTTP_REMOTEUSER"
 
-if os.environ.get("PULP_OAUTH2", "false").lower() == "true":
-    assert os.environ.get("PULP_HTTPS", "false").lower() == "true"
+if pulp_oauth2:
+    assert pulp_https
 
     def PulpCliFakeOauth2Authentication(*args, **kwargs):
         # We need to lazy load this.
         # Otherwise views may be instanciated, before this configuration is merged.
 
-        from django.contrib.auth import authenticate
+        from django.contrib.auth import get_user_model
         from drf_spectacular.extensions import OpenApiAuthenticationExtension
         from rest_framework.authentication import BaseAuthentication
 
         class _PulpCliFakeOauth2Authentication(BaseAuthentication):
             def authenticate(self, request):
                 auth_header = request.META.get("HTTP_AUTHORIZATION")
                 if auth_header == "Bearer DEADBEEF":
-                    return authenticate(request, remote_user="admin"), None
+                    return get_user_model().objects.get(username="admin"), None
                 else:
                     return None
 
@@ -54,5 +57,5 @@ def get_security_definition(self, auto_schema):
     PULP_CLI_FAKE_OAUTH2_AUTHENTICATION = PulpCliFakeOauth2Authentication
 
     REST_FRAMEWORK__DEFAULT_AUTHENTICATION_CLASSES = (
-        "@merge pulpcore.app.settings.PULP_CLI_FAKE_OAUTH2_AUTHENTICATION"
+        "pulpcore.app.settings.PULP_CLI_FAKE_OAUTH2_AUTHENTICATION",
     )

tests/scripts/pulp_container/test_role.sh

@@ -6,6 +6,8 @@ set -eu
 
 pulp debug has-plugin --name "file" --specifier ">=1.11.0" || exit 23
 
+[ "$(pulp debug openapi security-schemes | jq '.[]|select(.type=="http")|select(.scheme=="basic")|[.]|length')" = "1" ] || exit 23
+
 USERPASS="Yeech6ba"
 
 cleanup() {

tests/scripts/pulp_file/test_role.sh

@@ -4,6 +4,8 @@ set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 
+[ "$(pulp debug openapi security-schemes | jq '.[]|select(.type=="http")|select(.scheme=="basic")|[.]|length')" = "1" ] || exit 23
+
 USERPASS="Yeech6ba"
 
 cleanup() {