Add proper return value to sync task

Also address other tasks returning deprecated values that are ignored
anyway.

Author: mdellweg

CHANGES/+sync_result.bugfix

@@ -0,0 +1 @@
+Allow sync and build tasks to properly return the created repository_version (depends on pulpcore to support task results).

pulp_container/app/tasks/builder.py

@@ -5,22 +5,23 @@
 import tempfile
 from uuid import uuid4
 
+from pulpcore.plugin.models import (
+    Artifact,
+    ContentArtifact,
+    Content,
+    PulpTemporaryFile,
+)
+from pulpcore.plugin.util import get_domain
+
+from pulp_container.constants import MEDIA_TYPE
 from pulp_container.app.models import (
     Blob,
     BlobManifest,
     ContainerRepository,
     Manifest,
     Tag,
 )
-from pulp_container.constants import MEDIA_TYPE
 from pulp_container.app.utils import calculate_digest
-from pulpcore.plugin.models import (
-    Artifact,
-    ContentArtifact,
-    Content,
-    PulpTemporaryFile,
-)
-from pulpcore.plugin.util import get_domain
 
 
 def get_or_create_blob(layer_json, manifest, path):
@@ -193,6 +194,16 @@ def build_image(
             containerfile_artifact.delete()
 
     return repository_version
+    if repository_version:
+        try:
+            from pulpcore.plugin.serializers import RepositoryVersionSerializer
+
+            repository_version = RepositoryVersionSerializer(
+                instance=repository_version, context={"request": None}
+            ).data
+        except ImportError:
+            pass
+    return repository_version
 
 
 def build_image_from_containerfile(

pulp_container/app/tasks/download_image_data.py

@@ -16,8 +16,7 @@
 log = logging.getLogger(__name__)
 
 
-async def aadd_and_remove(*args, **kwargs):
-    return await sync_to_async(add_and_remove)(*args, **kwargs)
+aadd_and_remove = sync_to_async(add_and_remove)
 
 
 def download_image_data(repository_pk, remote_pk, raw_text_manifest_data, tag_name):
@@ -26,7 +25,7 @@ def download_image_data(repository_pk, remote_pk, raw_text_manifest_data, tag_na
     log.info("Pulling cache: repository={r} remote={p}".format(r=repository.name, p=remote.name))
     first_stage = ContainerPullThroughFirstStage(remote, raw_text_manifest_data, tag_name)
     dv = ContainerDeclarativeVersion(first_stage, repository)
-    return dv.create()
+    dv.create()
 
 
 class ContainerPullThroughFirstStage(ContainerFirstStage):

pulp_container/app/tasks/synchronize.py

@@ -38,7 +38,15 @@ def synchronize(remote_pk, repository_pk, mirror, signed_only):
     log.info("Synchronizing: repository={r} remote={p}".format(r=repository.name, p=remote.name))
     first_stage = ContainerFirstStage(remote, signed_only)
     dv = ContainerDeclarativeVersion(first_stage, repository, mirror)
-    return dv.create()
+    rv = dv.create()
+    if rv:
+        try:
+            from pulpcore.plugin.serializers import RepositoryVersionSerializer
+
+            rv = RepositoryVersionSerializer(instance=rv, context={"request": None}).data
+        except ImportError:
+            pass
+    return rv
 
 
 class ContainerDeclarativeVersion(DeclarativeVersion):