Fix leaking file descriptors in streamed download

Fixes #7157

Co-authored-by: Gerrod <[email protected]>
(cherry picked from commit 4307aaa)

Author: 2 people

CHANGES/7157.bugfix

@@ -0,0 +1 @@
+Fixed file handle leak when content app access triggers downloads due to on_demand or streamed policy.

pulpcore/content/handler.py

@@ -1334,6 +1334,12 @@ async def finalize():
                 "on-demand-downloading/#on-demand-and-streamed-limitations>"
             )
 
+        # manually close the DownloadFactory's (HTTP-)session, the next artifact-download will
+        # create a new DownloadFactory anyway because it will use a new remote-object.
+        # Leaving it open also left open file-descriptors to /dev/urandom. Most likely these FDs are
+        # held by the underlying SSL library.
+        await downloader.session.close()
+
         if save_artifact and remote.policy != Remote.STREAMED:
             content_artifacts = await asyncio.shield(
                 sync_to_async(self._save_artifact)(download_result, remote_artifact, request)