Skip to content

Commit 53f2f33

Browse files
committed
Remove exception tracebacks from failed tasks
Tracebacks can expose sensitive information from an exception via the API. This change stops this behavior by only logging tracebacks and not storing them inside of tasks.
1 parent 4464836 commit 53f2f33

File tree

30 files changed

+250
-94
lines changed

30 files changed

+250
-94
lines changed

.ci/assets/ci_constraints.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@ tablib!=3.6.0
88

99
multidict!=6.3.0
1010
# This release failed the lower bounds test for some case sensitivity in CIMultiDict.
11+
12+
13+
azure-storage-blob!=12.28.*
14+
# Apperently does not work with current azurite.

.github/workflows/update_ci.yml

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,37 @@ jobs:
7474
env:
7575
GH_TOKEN: "${{ secrets.RELEASE_TOKEN }}"
7676
continue-on-error: true
77+
- uses: "actions/checkout@v4"
78+
with:
79+
fetch-depth: 0
80+
path: "pulpcore"
81+
ref: "3.100"
82+
83+
- name: "Run update"
84+
working-directory: "pulpcore"
85+
run: |
86+
../plugin_template/scripts/update_ci.sh --release
87+
88+
- name: "Create Pull Request for CI files"
89+
uses: "peter-evans/create-pull-request@v6"
90+
id: "create_pr_3_100"
91+
with:
92+
token: "${{ secrets.RELEASE_TOKEN }}"
93+
path: "pulpcore"
94+
committer: "pulpbot <pulp-infra@redhat.com>"
95+
author: "pulpbot <pulp-infra@redhat.com>"
96+
title: "Update CI files for branch 3.100"
97+
branch: "update-ci/3.100"
98+
base: "3.100"
99+
delete-branch: true
100+
- name: "Mark PR automerge"
101+
working-directory: "pulpcore"
102+
run: |
103+
gh pr merge --rebase --auto "${{ steps.create_pr_3_100.outputs.pull-request-number }}"
104+
if: "steps.create_pr_3_100.outputs.pull-request-number"
105+
env:
106+
GH_TOKEN: "${{ secrets.RELEASE_TOKEN }}"
107+
continue-on-error: true
77108
- uses: "actions/checkout@v4"
78109
with:
79110
fetch-depth: 0
@@ -229,35 +260,4 @@ jobs:
229260
env:
230261
GH_TOKEN: "${{ secrets.RELEASE_TOKEN }}"
231262
continue-on-error: true
232-
- uses: "actions/checkout@v4"
233-
with:
234-
fetch-depth: 0
235-
path: "pulpcore"
236-
ref: "3.95"
237-
238-
- name: "Run update"
239-
working-directory: "pulpcore"
240-
run: |
241-
../plugin_template/scripts/update_ci.sh --release
242-
243-
- name: "Create Pull Request for CI files"
244-
uses: "peter-evans/create-pull-request@v6"
245-
id: "create_pr_3_95"
246-
with:
247-
token: "${{ secrets.RELEASE_TOKEN }}"
248-
path: "pulpcore"
249-
committer: "pulpbot <pulp-infra@redhat.com>"
250-
author: "pulpbot <pulp-infra@redhat.com>"
251-
title: "Update CI files for branch 3.95"
252-
branch: "update-ci/3.95"
253-
base: "3.95"
254-
delete-branch: true
255-
- name: "Mark PR automerge"
256-
working-directory: "pulpcore"
257-
run: |
258-
gh pr merge --rebase --auto "${{ steps.create_pr_3_95.outputs.pull-request-number }}"
259-
if: "steps.create_pr_3_95.outputs.pull-request-number"
260-
env:
261-
GH_TOKEN: "${{ secrets.RELEASE_TOKEN }}"
262-
continue-on-error: true
263263
...

CHANGES.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,44 @@
88

99
[//]: # (towncrier release notes start)
1010

11+
## 3.100.0 (2026-01-06) {: #3.100.0 }
12+
13+
### REST API {: #3.100.0-rest-api }
14+
15+
#### Features {: #3.100.0-rest-api-feature }
16+
17+
- Adapted PulpImport/Export to allow update django-import-export==4.x.
18+
[#5324](https://github.com/pulp/pulpcore/issues/5324)
19+
- Allow use of Django5 as well as Django4.
20+
[#6988](https://github.com/pulp/pulpcore/issues/6988)
21+
22+
#### Bugfixes {: #3.100.0-rest-api-bugfix }
23+
24+
- Fixed file handle leak when content app access triggers downloads due to on_demand or streamed policy.
25+
[#7157](https://github.com/pulp/pulpcore/issues/7157)
26+
27+
#### Misc {: #3.100.0-rest-api-misc }
28+
29+
-
30+
31+
### Plugin API {: #3.100.0-plugin-api }
32+
33+
#### Removals {: #3.100.0-plugin-api-removal }
34+
35+
- Removed the fallback for unserializable task return values.
36+
Tasks resulting from an api action should use the corresponding serializer to produce useful output. Maintenance tasks should return nothing.
37+
[#6079](https://github.com/pulp/pulpcore/issues/6079)
38+
39+
### Pulp File {: #3.100.0-pulp-file }
40+
41+
No significant changes.
42+
43+
### Pulp Cert Guard {: #3.100.0-pulp-cert-guard }
44+
45+
No significant changes.
46+
47+
---
48+
1149
## 3.95.3 (2025-12-17) {: #3.95.3 }
1250

1351
### REST API {: #3.95.3-rest-api }

CHANGES/+db_encryption.docs

Lines changed: 0 additions & 1 deletion
This file was deleted.

CHANGES/+improve-migration-err-msg.misc

Lines changed: 0 additions & 2 deletions
This file was deleted.

CHANGES/+no-traceback-task.removal

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Stopped leaking sensitive information of failures in the task API.

CHANGES/+signing.docs

Lines changed: 0 additions & 1 deletion
This file was deleted.

CHANGES/7157.bugfix

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Added `modify_task` property to `ModifyRepositoryActionMixin` so plugin writers can override the
2+
task that Pulp calls.

pulp_certguard/app/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ class PulpCertGuardPluginAppConfig(PulpPluginAppConfig):
66

77
name = "pulp_certguard.app"
88
label = "certguard"
9-
version = "3.96.0.dev"
9+
version = "3.101.0.dev"
1010
python_package_name = "pulpcore"
1111
domain_compatible = True

0 commit comments

Comments
 (0)