New exception class for declarative artifact init errors added

Author: Aliaksei Klimau

pulpcore/exceptions/__init__.py

@@ -7,6 +7,7 @@
     DnsDomainNameException,
     ImmediateTaskTimeoutError,
     NonAsyncImmediateTaskError,
+    DeclarativeArtifactValidationError,
 )
 from .validation import (
     DigestValidationError,

pulpcore/exceptions/base.py

@@ -155,3 +155,20 @@ def __str__(self):
         return _("Immediate task '{task_name}' must be an async function.").format(
             task_name=self.task_name
         )
+
+
+class DeclarativeArtifactValidationError(PulpException):
+    """
+    Exception raised when DeclarativeArtifact validation fails during initialization.
+    """
+
+    def __init__(self, message):
+        """
+        :param message: A translated string describing the specific validation failure.
+        :type message: str
+        """
+        super().__init__("PLP0011")
+        self.message = message
+
+    def __str__(self):
+        return self.message

pulpcore/plugin/stages/models.py

@@ -4,6 +4,7 @@
 
 from pulpcore.constants import ALL_KNOWN_CONTENT_CHECKSUMS
 from pulpcore.plugin.models import Artifact
+from pulpcore.exceptions import DeclarativeArtifactValidationError
 
 
 class DeclarativeArtifact:
@@ -33,7 +34,7 @@ class DeclarativeArtifact:
             in the artifact stages. Defaults to `False`. See :ref:`on-demand-support`.
 
     Raises:
-        ValueError: If `artifact`, `url`, or `relative_path` are not specified. If `remote` is not
+        DeclarativeArtifactValidationError: If `artifact`, `url`, or `relative_path` are not specified. If `remote` is not
         specified and `artifact` doesn't have a file.
     """
 
@@ -57,15 +58,27 @@ def __init__(
         deferred_download=False,
     ):
         if not (url or urls):
-            raise ValueError(_("DeclarativeArtifact must have a at least one 'url' provided"))
+            raise DeclarativeArtifactValidationError(
+                _("DeclarativeArtifact must have a at least one 'url' provided")
+            )
+
         if url and urls:
-            raise ValueError(_("DeclarativeArtifact must not provide both 'url' and 'urls'"))
+            raise DeclarativeArtifactValidationError(
+                _("DeclarativeArtifact must not provide both 'url' and 'urls'")
+            )
+
         if not relative_path:
-            raise ValueError(_("DeclarativeArtifact must have a 'relative_path'"))
+            raise DeclarativeArtifactValidationError(
+                _("DeclarativeArtifact must have a 'relative_path'")
+            )
+
         if not artifact:
-            raise ValueError(_("DeclarativeArtifact must have a 'artifact'"))
+            raise DeclarativeArtifactValidationError(
+                _("DeclarativeArtifact must have a 'artifact'")
+            )
+
         if not remote and not artifact.file:
-            raise ValueError(
+            raise DeclarativeArtifactValidationError(
                 _(
                     "DeclarativeArtifact must have a 'remote' if the Artifact doesn't "
                     "have a file backing it."