Proxy authentication exception catch reworked

Author: aKlimau

pulpcore/download/http.py

@@ -272,7 +272,7 @@ async def download_wrapper():
                             e.message,
                         )
                     )
-                    raise e
+                    raise ProxyAuthenticationRequiredError(self.proxy)
 
             return await download_wrapper()
 
@@ -301,8 +301,6 @@ async def _run(self, extra_data=None):
                 await response.release()
         except aiohttp.ClientConnectorDNSError:
             raise DnsDomainNameException(self.url)
-        except aiohttp.ClientHttpProxyError:
-            raise ProxyAuthenticationRequiredError(self.proxy)
         if self._close_session_on_finalize:
             await self.session.close()
         return to_return

pulpcore/tasking/tasks.py

@@ -82,8 +82,11 @@ def _execute_task(task):
         except Exception:
             exc_type, exc, tb = sys.exc_info()
             log_task_failed(task, exc_type, exc, tb, domain)
-            # Generic exception for user
-            safe_exc = Exception("An internal error occured.")
+            # Generic exception for user (temporarily including debug info)
+            safe_exc = Exception(
+                f"An internal error occured. "
+                f"[DEBUG: {exc_type.__name__}: {str(exc)}]"
+            )
             task.set_failed(safe_exc)
             send_task_notification(task)
         else:
@@ -114,8 +117,11 @@ async def _aexecute_task(task):
         except Exception:
             exc_type, exc, tb = sys.exc_info()
             log_task_failed(task, exc_type, exc, tb, domain)
-            # Generic exception for user
-            safe_exc = Exception("An internal error occured.")
+            # Generic exception for user (temporarily including debug info)
+            safe_exc = Exception(
+                f"An internal error occured. "
+                f"[DEBUG: {exc_type.__name__}: {str(exc)}]"
+            )
             await sync_to_async(task.set_failed)(safe_exc)
             send_task_notification(task)
         else: