Merge pull request #295 from pulsar-edit/noisy-webhook-logs

Fix package version updates not appearing on Discord notifications

Author: confused-Techie

src/controllers/postPackagesPackageNameVersions.js

@@ -44,29 +44,20 @@ module.exports = {
 
     // Lets bail early in case these values don't exist.
     // Such as the original request failing
-
-    if (
-      typeof obj?.webhook?.pack !== "string" ||
-      typeof obj?.webhook?.user !== "string"
-    ) {
+    if (!obj.webhook || !obj.featureDetection) {
       // This data isn't defined, and we cannot work with it
       return;
     }
 
-    if (
-      typeof obj?.featureDetection?.user !== "string" ||
-      typeof obj?.featureDetection?.ownerRepo !== "string" ||
-      typeof obj?.featureDetection?.service !== "string"
-    ) {
-      // This data isn't defined, and we cannot work with it
-      return;
-    }
-
-    await context.webhook.alertPublishVersion(
+    let webhookSend = await context.webhook.alertPublishVersion(
       obj.webhook.pack,
       obj.webhook.user
     );
 
+    if (!webhookSend.ok) {
+      context.logger.generic(3, webhookSend);
+    }
+
     // Now to call for feature detection
     let features = await context.vcs.featureDetection(
       obj.featureDetection.user,