Skip to content

Commit 69eca0d

Browse files
committed
fix: remove unsupported '--' separator from wasmtime commands
The TinyGo file operations component doesn't accept '--' as an argument separator. All wasmtime run commands in the performance workflow have been updated to call the component directly without the separator. Changes: - Removed '--' from all wasmtime commands in benchmark steps - Removed '--' from resource profiling commands - Removed '--' from performance regression detection commands This fixes the hyperfine benchmark failures in the Performance Monitoring workflow. Tested locally: - Regular component build: ✅ - AOT component build: ✅ - OCI image build: ✅ - Component execution: ✅
1 parent bceddf1 commit 69eca0d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/performance.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,14 @@ jobs:
120120
if command -v wasmtime &> /dev/null; then
121121
# Test the command first to see if it works
122122
echo "Testing WASM component execution..."
123-
if wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src perf_test_data/small.txt --dest perf_test_data/wasm_copy.txt; then
123+
if wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src perf_test_data/small.txt --dest perf_test_data/wasm_copy.txt; then
124124
echo "✅ WASM component test passed, running benchmarks..."
125125
126126
# Run benchmark with proper error handling
127127
hyperfine --export-json tinygo_wasm_benchmark.json \
128128
--warmup 3 \
129129
--show-output \
130-
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src perf_test_data/small.txt --dest perf_test_data/wasm_copy.txt' \
130+
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src perf_test_data/small.txt --dest perf_test_data/wasm_copy.txt' \
131131
|| echo "⚠️ Benchmark failed but continuing" >> perf_results.md
132132
133133
echo "✅ TinyGo component benchmarks completed" >> perf_results.md
@@ -156,7 +156,7 @@ jobs:
156156
# WebAssembly runtime benchmark
157157
if command -v wasmtime &> /dev/null; then
158158
hyperfine --export-json rust_wasm_benchmark.json \
159-
'wasmtime run --dir=. bazel-bin/rust/file_ops_component_wasm.wasm -- copy_file --src perf_test_data/small.txt --dest perf_test_data/rust_wasm_copy.txt'
159+
'wasmtime run --dir=. bazel-bin/rust/file_ops_component_wasm.wasm copy_file --src perf_test_data/small.txt --dest perf_test_data/rust_wasm_copy.txt'
160160
fi
161161
162162
- name: Performance Comparison Analysis
@@ -274,7 +274,7 @@ jobs:
274274
275275
# Profile TinyGo WebAssembly component
276276
echo "### TinyGo Component (WASM)" >> profile_results.md
277-
/usr/bin/time -v wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src profile_test.dat --dest profile_copy.dat 2>&1 | \
277+
/usr/bin/time -v wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src profile_test.dat --dest profile_copy.dat 2>&1 | \
278278
grep -E "(Maximum resident set size|User time|System time)" >> profile_results.md || echo "Profiling data not available" >> profile_results.md
279279
280280
- name: Profile WebAssembly Runtime Memory
@@ -284,7 +284,7 @@ jobs:
284284
echo "" >> profile_results.md
285285
286286
# Profile WASM component memory usage with detailed stats
287-
/usr/bin/time -v wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src profile_test.dat --dest wasm_profile_copy.dat 2>&1 | \
287+
/usr/bin/time -v wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src profile_test.dat --dest wasm_profile_copy.dat 2>&1 | \
288288
grep -E "(Maximum resident set size|User time|System time)" >> profile_results.md || echo "Detailed profiling data not available" >> profile_results.md
289289
290290
- name: Upload Profiling Results
@@ -348,7 +348,7 @@ jobs:
348348
# Benchmark baseline using WASM component
349349
hyperfine --export-json baseline_results/baseline_benchmark.json \
350350
--warmup 3 \
351-
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src baseline_test.txt --dest baseline_copy.txt'
351+
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src baseline_test.txt --dest baseline_copy.txt'
352352
353353
- name: Checkout PR Branch
354354
run: |
@@ -362,7 +362,7 @@ jobs:
362362
# Benchmark PR changes using WASM component
363363
hyperfine --export-json pr_results/pr_benchmark.json \
364364
--warmup 3 \
365-
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm -- copy_file --src baseline_test.txt --dest pr_copy.txt'
365+
'wasmtime run --dir=. bazel-bin/tinygo/file_ops_component.wasm copy_file --src baseline_test.txt --dest pr_copy.txt'
366366
367367
- name: Analyze Performance Regression
368368
run: |

0 commit comments

Comments
 (0)