fix: critical resource delegation bug in mcp_server macro

CRITICAL: This fixes the main issue in v0.9.0 where resources were not working.

Changes:
- Fix mcp_server macro to properly delegate to McpResourcesProvider trait
- Ensure McpResourcesProvider trait is always implemented (like McpToolsProvider)
- Generate empty implementation when no resources are defined
- Update helper methods to work with always-available trait
- Version bump to 0.9.1 for emergency patch release

Resources now work properly:
- resources/list shows actual resources instead of empty array
- resources/read works for non-parameterized resources
- No compilation errors for servers without resources
- All examples compile and work correctly

Resolves the broken resource functionality shipped in v0.9.0.

Author: avrabe

.claude/settings.local.json

@@ -36,8 +36,9 @@
       "mcp__puppeteer__puppeteer_evaluate",
       "WebFetch(domain:lib.rs)",
       "WebFetch(domain:raw.githubusercontent.com)",
-      "Bash(npx @modelcontextprotocol/inspector:*)"
+      "Bash(npx @modelcontextprotocol/inspector:*)",
+      "Bash(./target/release/timedate-mcp-server:*)"
     ],
     "deny": []
   }
-}
+}

Cargo.lock

@@ -27,7 +27,7 @@ members = [
 resolver = "2"
 
 [workspace.package]
-version = "0.9.0"
+version = "0.9.1"
 rust-version = "1.88"
 edition = "2024"
 license = "MIT OR Apache-2.0"
@@ -101,17 +101,17 @@ assert_matches = "1.5"
 serde_yaml = "0.9"
 
 # Framework internal dependencies (published versions)
-pulseengine-mcp-protocol = { version = "0.9.0", path = "mcp-protocol" }
-pulseengine-mcp-logging = { version = "0.9.0", path = "mcp-logging" }
-pulseengine-mcp-auth = { version = "0.9.0", path = "mcp-auth" }
-pulseengine-mcp-security = { version = "0.9.0", path = "mcp-security" }
-pulseengine-mcp-monitoring = { version = "0.9.0", path = "mcp-monitoring" }
-pulseengine-mcp-transport = { version = "0.9.0", path = "mcp-transport" }
-pulseengine-mcp-cli = { version = "0.9.0", path = "mcp-cli" }
-pulseengine-mcp-cli-derive = { version = "0.9.0", path = "mcp-cli-derive" }
-pulseengine-mcp-server = { version = "0.9.0", path = "mcp-server" }
-pulseengine-mcp-macros = { version = "0.9.0", path = "mcp-macros" }
-pulseengine-mcp-external-validation = { version = "0.9.0", path = "mcp-external-validation" }
+pulseengine-mcp-protocol = { version = "0.9.1", path = "mcp-protocol" }
+pulseengine-mcp-logging = { version = "0.9.1", path = "mcp-logging" }
+pulseengine-mcp-auth = { version = "0.9.1", path = "mcp-auth" }
+pulseengine-mcp-security = { version = "0.9.1", path = "mcp-security" }
+pulseengine-mcp-monitoring = { version = "0.9.1", path = "mcp-monitoring" }
+pulseengine-mcp-transport = { version = "0.9.1", path = "mcp-transport" }
+pulseengine-mcp-cli = { version = "0.9.1", path = "mcp-cli" }
+pulseengine-mcp-cli-derive = { version = "0.9.1", path = "mcp-cli-derive" }
+pulseengine-mcp-server = { version = "0.9.1", path = "mcp-server" }
+pulseengine-mcp-macros = { version = "0.9.1", path = "mcp-macros" }
+pulseengine-mcp-external-validation = { version = "0.9.1", path = "mcp-external-validation" }
 
 [profile.release]
 opt-level = "s"

Cargo.toml

@@ -218,14 +218,18 @@ fn generate_server_implementation(
                 }
             }
 
-            async fn list_resources(&self, _request: pulseengine_mcp_protocol::PaginatedRequestParam) -> std::result::Result<pulseengine_mcp_protocol::ListResourcesResult, Self::Error> {
-                // Default implementation - no resources
-                Ok(pulseengine_mcp_protocol::ListResourcesResult { resources: vec![], next_cursor: None })
+            async fn list_resources(&self, request: pulseengine_mcp_protocol::PaginatedRequestParam) -> std::result::Result<pulseengine_mcp_protocol::ListResourcesResult, Self::Error> {
+                // Use helper method that safely checks for trait implementation
+                let resources = self.try_get_resources_default();
+                Ok(pulseengine_mcp_protocol::ListResourcesResult { resources, next_cursor: request.cursor })
             }
 
             async fn read_resource(&self, request: pulseengine_mcp_protocol::ReadResourceRequestParam) -> std::result::Result<pulseengine_mcp_protocol::ReadResourceResult, Self::Error> {
-                // Default implementation - no resources
-                Err(#error_type_name::InvalidParams(format!("Unknown resource: {}", request.uri)))
+                // Use helper method that calls resource implementation
+                match self.try_read_resource_default(request.clone()).await {
+                    Ok(result) => Ok(result),
+                    Err(e) => Err(#error_type_name::InvalidParams(e.to_string()))
+                }
             }
 
             async fn list_prompts(&self, _request: pulseengine_mcp_protocol::PaginatedRequestParam) -> std::result::Result<pulseengine_mcp_protocol::ListPromptsResult, Self::Error> {

mcp-macros/src/mcp_server.rs

@@ -318,7 +318,7 @@ pub fn mcp_tools_impl(_attr: TokenStream, item: TokenStream) -> syn::Result<Toke
         }
     }
 
-    // Generate resource provider implementation if there are resources
+    // Always generate resource provider implementation (like tools)
     let resource_provider_impl = if !resource_definitions.is_empty() {
         quote! {
             impl #impl_generics pulseengine_mcp_server::McpResourcesProvider for #struct_name #ty_generics #where_clause {
@@ -345,7 +345,25 @@ pub fn mcp_tools_impl(_attr: TokenStream, item: TokenStream) -> syn::Result<Toke
             }
         }
     } else {
-        quote! {}
+        // Generate empty implementation when no resources are defined
+        quote! {
+            impl #impl_generics pulseengine_mcp_server::McpResourcesProvider for #struct_name #ty_generics #where_clause {
+                fn get_available_resources(&self) -> Vec<pulseengine_mcp_protocol::Resource> {
+                    vec![]
+                }
+
+                fn read_resource_impl(
+                    &self,
+                    request: pulseengine_mcp_protocol::ReadResourceRequestParam,
+                ) -> impl std::future::Future<Output = std::result::Result<pulseengine_mcp_protocol::ReadResourceResult, pulseengine_mcp_protocol::Error>> + Send {
+                    async move {
+                        Err(pulseengine_mcp_protocol::Error::invalid_params(
+                            format!("Unknown resource: {}", request.uri)
+                        ))
+                    }
+                }
+            }
+        }
     };
 
     // Resource backend override temporarily disabled to avoid trait conflicts
@@ -780,7 +798,13 @@ fn generate_helper_methods(
             /// Helper method to check if resources are available (used in tests)
             #[allow(dead_code)]
             pub fn try_get_resources_default(&self) -> Vec<pulseengine_mcp_protocol::Resource> {
-                vec![] // Return empty for now to avoid trait bound issues
+                <Self as pulseengine_mcp_server::McpResourcesProvider>::get_available_resources(self)
+            }
+
+            /// Helper method to read resources (used by mcp_server macro)
+            #[allow(dead_code)]
+            pub async fn try_read_resource_default(&self, request: pulseengine_mcp_protocol::ReadResourceRequestParam) -> std::result::Result<pulseengine_mcp_protocol::ReadResourceResult, pulseengine_mcp_protocol::Error> {
+                <Self as pulseengine_mcp_server::McpResourcesProvider>::read_resource_impl(self, request).await
             }
         }
     }