Skip to content

Commit 068870c

Browse files
committed
fix: resolve GitHub Actions workflow syntax errors
Move secret access to job-level environment variables to avoid 'Unrecognized named-value: secrets' errors in conditional expressions. This follows GitHub Actions best practices for secret handling.
1 parent d056c24 commit 068870c

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

.github/workflows/docs-deploy.yml

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ jobs:
1818
runs-on: ubuntu-latest
1919
# Only run on main branch to prevent accidental deployments
2020
if: github.ref == 'refs/heads/main'
21+
env:
22+
NETCUP_URI: ${{ secrets.NETCUP_URI }}
23+
NETCUP_USER: ${{ secrets.NETCUP_USER }}
24+
NETCUP_PASSWORD: ${{ secrets.NETCUP_PASSWORD }}
25+
CLOUDFLARE_ZONE_ID: ${{ secrets.CLOUDFLARE_ZONE_ID }}
26+
CLOUDFLARE_TOKEN: ${{ secrets.CLOUDFLARE_TOKEN }}
2127
steps:
2228
- name: Checkout repository
2329
uses: actions/checkout@v4
@@ -44,9 +50,9 @@ jobs:
4450
if: env.NETCUP_URI != '' && env.NETCUP_USER != '' && env.NETCUP_PASSWORD != ''
4551
uses: SamKirkland/[email protected]
4652
with:
47-
server: ${{ secrets.NETCUP_URI }}
48-
username: ${{ secrets.NETCUP_USER }}
49-
password: ${{ secrets.NETCUP_PASSWORD }}
53+
server: ${{ env.NETCUP_URI }}
54+
username: ${{ env.NETCUP_USER }}
55+
password: ${{ env.NETCUP_PASSWORD }}
5056
local-dir: ./docs-site/dist/
5157
server-dir: /
5258
exclude: |
@@ -55,23 +61,14 @@ jobs:
5561
**/node_modules/**
5662
**/.DS_Store
5763
**/Thumbs.db
58-
env:
59-
NETCUP_URI: ${{ secrets.NETCUP_URI }}
60-
NETCUP_USER: ${{ secrets.NETCUP_USER }}
61-
NETCUP_PASSWORD: ${{ secrets.NETCUP_PASSWORD }}
6264
6365
- name: Skip deployment (secrets not configured)
6466
if: env.NETCUP_URI == '' || env.NETCUP_USER == '' || env.NETCUP_PASSWORD == ''
6567
run: echo "Skipping deployment - Netcup secrets not configured"
66-
env:
67-
NETCUP_URI: ${{ secrets.NETCUP_URI }}
68-
NETCUP_USER: ${{ secrets.NETCUP_USER }}
69-
NETCUP_PASSWORD: ${{ secrets.NETCUP_PASSWORD }}
7068

7169
- name: Purge Cloudflare cache (optional)
7270
if: env.CLOUDFLARE_ZONE_ID != ''
7371
uses: jakejarvis/cloudflare-purge-action@master
74-
env:
75-
CLOUDFLARE_ZONE: ${{ secrets.CLOUDFLARE_ZONE_ID }}
76-
CLOUDFLARE_TOKEN: ${{ secrets.CLOUDFLARE_TOKEN }}
77-
CLOUDFLARE_ZONE_ID: ${{ secrets.CLOUDFLARE_ZONE_ID }}
72+
with:
73+
zone: ${{ env.CLOUDFLARE_ZONE_ID }}
74+
token: ${{ env.CLOUDFLARE_TOKEN }}

0 commit comments

Comments
 (0)