fix: correct buildifier.json format and adjust CI lint checks

- Fix buildifier.json to use correct field names (warningsList not warnings)
- Use proper JSON structure based on buildifier -config=example output
- Make CI check formatting strictly but show lint warnings as informational
- Set local mode to 'fix' for developer convenience

Author: avrabe

.buildifier.json

@@ -1,15 +1,19 @@
 {
-  "version": 4,
-  "lint": {
-    "mode": "warn",
-    "warnings": [
-      "+load",
-      "+load-on-top",
-      "+out-of-order-load", 
-      "+unused-variable",
-      "+function-docstring",
-      "+function-docstring-args",
-      "+print"
-    ]
-  }
+  "type": "auto",
+  "mode": "fix",
+  "lint": "warn",
+  "warningsList": [
+    "load",
+    "load-on-top",
+    "out-of-order-load",
+    "unused-variable",
+    "function-docstring",
+    "function-docstring-args",
+    "print",
+    "module-docstring",
+    "name-conventions",
+    "redefined-variable",
+    "same-origin-load",
+    "unreachable"
+  ]
 }

.github/workflows/ci.yml

@@ -26,13 +26,14 @@ jobs:
     - name: Check Buildifier Formatting
       run: |
         echo "Checking Bazel file formatting..."
-        bazel run //:buildifier -- --lint=warn --mode=check -r .
+        # Check only formatting, not lint warnings (for now)
+        bazel run //:buildifier -- --mode=check -r .
     
-    - name: Check for Unused Dependencies
+    - name: Show Lint Warnings (Informational)
       run: |
-        echo "Checking for unused dependencies in BUILD files..."
-        # This will warn about unused deps but not fail the build
-        bazel run //:buildifier -- --lint=warn --warnings=load -r . || true
+        echo "Showing lint warnings (informational only - won't fail the build)..."
+        # Show warnings but don't fail the CI
+        bazel run //:buildifier -- --lint=warn --mode=check -r . || true
 
   test:
     name: Test on ${{ matrix.os }}