Skip to content

Commit 4038771

Browse files
committed
fix(windows): use .exe extension for Go and wasm-opt binaries on Windows
1 parent 3d33077 commit 4038771

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

toolchains/tinygo_toolchain.bzl

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ def _download_go(repository_ctx, version, platform):
5959
stripPrefix = "go",
6060
)
6161

62-
# Verify Go installation
63-
go_binary = repository_ctx.path("go_sdk/bin/go")
62+
# Verify Go installation (use .exe on Windows)
63+
go_binary_name = "go.exe" if platform == "windows_amd64" else "go"
64+
go_binary = repository_ctx.path("go_sdk/bin/{}".format(go_binary_name))
6465
if not go_binary.exists:
6566
fail("Go binary not found after download: {}".format(go_binary))
6667

@@ -303,14 +304,14 @@ filegroup(
303304
# Go binary for TinyGo
304305
alias(
305306
name = "go_binary",
306-
actual = "go_sdk/bin/go",
307+
actual = "{go_binary_name}",
307308
visibility = ["//visibility:public"],
308309
)
309310
310311
# wasm-opt binary from Binaryen
311312
alias(
312313
name = "wasm_opt_binary",
313-
actual = "binaryen/bin/wasm-opt",
314+
actual = "{wasm_opt_binary_name}",
314315
visibility = ["//visibility:public"],
315316
)
316317
@@ -356,6 +357,8 @@ toolchain(
356357
)
357358
""".format(
358359
tinygo_binary_name = "tinygo/bin/tinygo",
360+
go_binary_name = "go_sdk/bin/go.exe" if platform == "windows_amd64" else "go_sdk/bin/go",
361+
wasm_opt_binary_name = "binaryen/bin/wasm-opt.exe" if platform == "windows_amd64" else "binaryen/bin/wasm-opt",
359362
os = "osx" if "darwin" in platform else ("windows" if "windows" in platform else "linux"),
360363
cpu = "arm64" if "arm64" in platform else "x86_64",
361364
))

0 commit comments

Comments
 (0)