Skip to content

Commit 4a45817

Browse files
committed
fix: enable working Go components with wit-bindgen, exclude manual exports
- Fix final crate name: checksum_updater_lib -> checksum_updater (line 227) - Re-enable calculator_with_bindings (uses generated WIT bindings - works!) - Keep exclusions only for manual export components (need migration) - Root cause: Manual //export directives don't work with Component Model - Solution: Use wit-bindgen-go generated bindings (like calculator_with_bindings)
1 parent 40d1f0a commit 4a45817

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

.github/workflows/ci.yml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,15 @@ jobs:
102102
- name: Build All Targets
103103
run: |
104104
# Build core working targets including JavaScript components
105-
# Excluding Go calculator components (TinyGo export issues, see #80)
105+
# Excluding Go components with manual exports (need wit-bindgen-go migration)
106106
bazel build --keep_going -- \
107+
//examples/go_component:calculator_with_bindings \
107108
//examples/go_component:http_service_component \
108109
//examples/go_component:http_service_docs \
109110
//examples/go_component:multi_file_test \
110111
//examples/go_component:simple_test \
111112
//examples/go_component:simple_wasi \
113+
//examples/go_component:calculator_wit \
112114
//examples/go_component:http_service_wit \
113115
//examples/basic/... \
114116
//examples/simple_module/... \
@@ -132,6 +134,13 @@ jobs:
132134
//test/integration/... \
133135
//docs-site/... \
134136
-//examples/cpp_component/multi_component_system:analytics_service \
137+
-//examples/go_component:calculator_component \
138+
-//examples/go_component:calculator_component_debug \
139+
-//examples/go_component:calculator_simple \
140+
-//examples/go_component:calculator_simple_binding \
141+
-//examples/go_component:calculator_manual \
142+
-//examples/go_component:calculator_docs \
143+
-//examples/go_component:simple_calculator_wit \
135144
-//tools/checksum_updater_wasm/... \
136145
-//tools/ssh_keygen:ssh_keygen_test \
137146
@@ -197,13 +206,15 @@ jobs:
197206
- name: Build All Targets
198207
run: |
199208
# Build core working targets using explicit inclusions
200-
# Excluding Go calculator components (TinyGo export issues, see #80)
209+
# Excluding Go components with manual exports (need wit-bindgen-go migration)
201210
bazel build --keep_going -- \
211+
//examples/go_component:calculator_with_bindings \
202212
//examples/go_component:http_service_component \
203213
//examples/go_component:http_service_docs \
204214
//examples/go_component:multi_file_test \
205215
//examples/go_component:simple_test \
206216
//examples/go_component:simple_wasi \
217+
//examples/go_component:calculator_wit \
207218
//examples/go_component:http_service_wit \
208219
//examples/basic/... \
209220
//examples/simple_module/... \
@@ -227,6 +238,13 @@ jobs:
227238
//test/integration/... \
228239
//docs-site/... \
229240
-//examples/cpp_component/multi_component_system:analytics_service \
241+
-//examples/go_component:calculator_component \
242+
-//examples/go_component:calculator_component_debug \
243+
-//examples/go_component:calculator_simple \
244+
-//examples/go_component:calculator_simple_binding \
245+
-//examples/go_component:calculator_manual \
246+
-//examples/go_component:calculator_docs \
247+
-//examples/go_component:simple_calculator_wit \
230248
-//examples/simple_oci_test/... \
231249
-//examples/microservices_architecture/... \
232250
-//test/integration:validate_consumer_deps \

tools/checksum_updater/tests/integration_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ async fn test_checksum_manager_file_operations() -> Result<()> {
224224
/// Test configuration parsing and tool configuration
225225
#[tokio::test]
226226
async fn test_tool_configuration() -> Result<()> {
227-
use checksum_updater_lib::tool_config::ToolConfig;
227+
use checksum_updater::tool_config::ToolConfig;
228228

229229
let tool_config = ToolConfig::default();
230230

0 commit comments

Comments
 (0)