Skip to content

Commit aade8ed

Browse files
committed
fix: resolve JS component action conflict and unit test visibility
- Make JS component WIT file names unique to prevent action conflicts - Add public visibility to unit_tests for language_support accessibility Resolves CI build failures where multiple JS components created the same component.wit symlink and test suites could not access unit tests.
1 parent 598ad34 commit aade8ed

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

js/defs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def _js_component_impl(ctx):
4646
)
4747

4848
# Copy WIT file to workspace (needed for jco componentize)
49-
wit_dest = ctx.actions.declare_file("component.wit")
49+
wit_dest = ctx.actions.declare_file(ctx.attr.name + "_component.wit")
5050
ctx.actions.symlink(
5151
output = wit_dest,
5252
target_file = wit_file,

test/unit/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,4 +104,5 @@ test_suite(
104104
":test_wit_library_basic",
105105
":test_wit_library_with_deps",
106106
],
107+
visibility = ["//visibility:public"],
107108
)

0 commit comments

Comments
 (0)