Skip to content

Commit cc88f65

Browse files
committed
fix: update macOS CI to use explicit inclusions like Linux
The macOS CI job was still using the old //... with exclusions approach while Linux was updated to explicit inclusions. This caused inconsistent behavior between platforms. Now both Linux and macOS CI jobs use the same explicit inclusion strategy: ✅ Explicitly include: - //examples/go_component/... (our hermetic Go toolchain) - //examples/basic/..., //examples/simple_module/..., //examples/cli_tool_example/... - //examples/cpp_component/... - //rust/..., //go/..., //cpp/..., //wasm/..., //wit/... - //test/go/..., //test/cpp/..., //test/unit/..., //test/integration/... ❌ Explicitly exclude problematic targets: - analytics_service (Go module path issues) - macOS-specific Docker-dependent targets This ensures consistent validation of our hermetic Go toolchain across platforms.
1 parent df12d73 commit cc88f65

File tree

1 file changed

+26
-39
lines changed

1 file changed

+26
-39
lines changed

.github/workflows/ci.yml

Lines changed: 26 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -185,45 +185,32 @@ jobs:
185185

186186
- name: Build All Targets
187187
run: |
188-
# Build core working targets, exclude incomplete/problematic examples
189-
# Additional exclusions for macOS where Docker services aren't available
190-
# and where some tools have configuration issues
191-
if [[ "$RUNNER_OS" == "macOS" ]]; then
192-
EXTRA_EXCLUDES="-//examples/simple_oci_test/... -//examples/microservices_architecture/... -//test/integration:validate_consumer_deps -//test_wit_deps/consumer:check_deps"
193-
else
194-
EXTRA_EXCLUDES=""
195-
fi
196-
197-
bazel build -- //... \
198-
-//examples/world_export/... \
199-
-//examples/multi_profile/... \
200-
-//examples/wac_remote_compose/... \
201-
-//examples/wac_oci_composition/... \
202-
-//examples/wkg_integration/... \
203-
-//examples/wizer_example/... \
204-
-//test_wac/... \
205-
-//test/wkg/... \
206-
-//test/production/... \
207-
-//tools-builder/... \
208-
$EXTRA_EXCLUDES \
209-
-//examples/wasm_signing/... \
210-
-//test_examples/... \
211-
-//test_wit_deps/... \
212-
-//examples/oci_publishing:secure_publish_enterprise \
213-
-//test/integration:multi_service_system \
214-
-//test/integration:composition_build_test \
215-
-//test/integration:integration_tests \
216-
-//test/export_macro:test_component_wasm_lib_release_host \
217-
-//test/integration:basic_component_wasm_lib_debug_host \
218-
-//test/integration:basic_component_wasm_lib_release_host \
219-
-//test/integration:consumer_component_wasm_lib_release_host \
220-
-//test/integration:service_a_component_wasm_lib_release_host \
221-
-//test/integration:service_b_component_wasm_lib_release_host \
222-
-//test/integration:wasi_component_wasm_lib_release_host \
223-
-//test/unit:test_component_simple_wasm_lib_release_host \
224-
-//test/unit:test_component_with_deps_wasm_lib_release_host \
225-
-//examples/basic:hello_component_wasm_lib_release_host \
226-
-//tools/checksum_updater_wasm:checksum_updater_wasm_wizer_component_release_wasm_lib_release_host
188+
# Build core working targets using explicit inclusions
189+
# Same approach as Linux but with macOS-specific exclusions
190+
bazel build -- \
191+
//examples/go_component/... \
192+
//examples/basic/... \
193+
//examples/simple_module/... \
194+
//examples/cli_tool_example/... \
195+
//examples/cpp_component/... \
196+
//rust/... \
197+
//go/... \
198+
//cpp/... \
199+
//wasm/... \
200+
//wit/... \
201+
//tools/... \
202+
//providers/... \
203+
//test/go/... \
204+
//test/cpp/... \
205+
//test/unit/... \
206+
//test/integration/... \
207+
//docs-site/... \
208+
-//examples/cpp_component/multi_component_system:analytics_service \
209+
-//examples/simple_oci_test/... \
210+
-//examples/microservices_architecture/... \
211+
-//test/integration:validate_consumer_deps \
212+
-//test_wit_deps/consumer:check_deps \
213+
--keep_going
227214
228215
- name: Run Tests
229216
run: bazel test --test_output=errors -- //test/integration:basic_component_build_test //test/integration:basic_component_validation //test/unit:unit_tests

0 commit comments

Comments
 (0)