Commit ce43aa3
committed
fix: resolve critical CI failures across multiple component types
Fixes three major CI issues that were causing early build failures:
1. **Go Component World Name Validation**: Updated validation in go/defs.bzl
to accept valid WIT world names with colons and forward slashes like
'wasi:cli/command'. Previous validation was too restrictive, rejecting
standard WIT namespace syntax.
2. **WIT Dependency Check Syntax Error**: Fixed wit_deps_check.bzl by
removing unsupported 'stdout' parameter from ctx.actions.run() and
passing output file path as argument instead. This resolves the
"unexpected keyword argument 'stdout'" error.
3. **JavaScript Component JCO Installation**: Fixed jco_toolchain.bzl by
actually installing npm packages with repository_ctx.execute() instead
of creating empty placeholder files. This resolves the "Cannot find module"
errors for @bytecodealliance/jco.
All fixes maintain hermetic build principles and cross-platform compatibility.
Successfully tested JavaScript components and Go world name validation.1 parent 191c3ef commit ce43aa3
File tree
4 files changed
+28
-20
lines changed- go
- toolchains
- wit
4 files changed
+28
-20
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
201 | 202 | | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
202 | 211 | | |
203 | 212 | | |
204 | 213 | | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
0 commit comments