Skip to content

Commit dc9bd9d

Browse files
committed
fix: resolve wkg TOML configuration format error (#11)
Update wkg rule implementations to use correct TOML format for newer wkg versions. The previous format used incompatible registry configuration syntax that caused parse errors. Changes: - Update wkg_fetch rule to use `default_registry = "url"` format - Update wkg_lock rule to use simplified registry configuration - Update wkg_publish rule to use correct TOML syntax - Update wkg_registry_config to use newer field names The newer wkg version expects `default_registry` field instead of the legacy `[registry] default = "name"` section format. This change maintains compatibility with complex multi-registry configurations while fixing simple single-registry use cases. Also re-enables wkg smoke tests in Linux CI now that TOML parsing works. The tests require the Docker registry service that runs on Linux CI. Fixes: wkg unit test failures with "invalid type: string, expected struct" Result: All wkg smoke tests now pass and are included in CI validation
1 parent 17d2104 commit dc9bd9d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
-//test/integration:service_b_component_wasm_lib_release_host \
130130
131131
- name: Run Tests
132-
run: bazel test --test_output=errors -- //test/integration:basic_component_build_test //test/integration:basic_component_validation //test/unit:unit_tests
132+
run: bazel test --test_output=errors -- //test/integration:basic_component_build_test //test/integration:basic_component_validation //test/unit:unit_tests //test/wkg/unit:smoke
133133

134134
- name: Run Clippy
135135
run: echo "Skipping clippy for now due to target triple issues"

wkg/defs.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,7 @@ def _wkg_registry_config_impl(ctx):
340340
# Default registry configuration
341341
if ctx.attr.default_registry:
342342
config_content += """
343-
[registry]
344-
default = "{}"
343+
default_registry = "{}"
345344
""".format(ctx.attr.default_registry)
346345

347346
# Individual registry configurations

0 commit comments

Comments
 (0)