Commit 2a86caf
committed
fix(ci): resolve critical compilation errors blocking all CI jobs
This commit fixes the root cause preventing cargo-wrt installation and
all subsequent CI job failures.
CRITICAL FIXES:
SIMD Syntax Errors (wrt-platform):
- Fix missing parentheses in x86_64.rs:1504: i_val.to_le_bytes()
- Fix missing parentheses in x86_64.rs:1517: u_val.to_le_bytes()
- Fix missing parentheses in x86_64.rs:1541: f_val.to_bits().to_le_bytes()
- Fix missing parentheses in mod.rs:504: X86SimdProvider::new_avx2()
- Fix missing parentheses in mod.rs:506: X86SimdProvider::new_sse2()
API Compatibility (wrt-build-core):
- Replace deprecated engine.instantiate() with engine.set_current_module()
- Fix type mismatch: create Arc<ModuleInstance> from Module
- Fix parameter type: convert func_idx from u32 to usize
- Correct import path: wrt_runtime::module_instance::ModuleInstance
IMPACT:
- cargo-wrt now compiles successfully
- All CI jobs should now be able to install cargo-wrt tool
- This unblocks ASIL verification, testing, and build matrix jobs
- Resolves cascading CI failures affecting PR #92 merge status
ROOT CAUSE ANALYSIS:
The 5 missing parentheses in SIMD code prevented wrt-platform compilation,
which blocked cargo-wrt installation, causing all CI jobs to fail within
15-30 seconds when they couldn't find the cargo-wrt binary.1 parent e1b2205 commit 2a86caf
File tree
3 files changed
+17
-9
lines changed- wrt-build-core/src
- wrt-platform/src/simd
3 files changed
+17
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
73 | 81 | | |
74 | 82 | | |
75 | | - | |
76 | | - | |
| 83 | + | |
| 84 | + | |
77 | 85 | | |
78 | 86 | | |
79 | 87 | | |
| |||
105 | 113 | | |
106 | 114 | | |
107 | 115 | | |
108 | | - | |
| 116 | + | |
109 | 117 | | |
110 | 118 | | |
111 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
501 | 501 | | |
502 | 502 | | |
503 | 503 | | |
504 | | - | |
| 504 | + | |
505 | 505 | | |
506 | | - | |
| 506 | + | |
507 | 507 | | |
508 | 508 | | |
509 | 509 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1501 | 1501 | | |
1502 | 1502 | | |
1503 | 1503 | | |
1504 | | - | |
| 1504 | + | |
1505 | 1505 | | |
1506 | 1506 | | |
1507 | 1507 | | |
| |||
1514 | 1514 | | |
1515 | 1515 | | |
1516 | 1516 | | |
1517 | | - | |
| 1517 | + | |
1518 | 1518 | | |
1519 | 1519 | | |
1520 | 1520 | | |
| |||
1538 | 1538 | | |
1539 | 1539 | | |
1540 | 1540 | | |
1541 | | - | |
| 1541 | + | |
1542 | 1542 | | |
1543 | 1543 | | |
1544 | 1544 | | |
| |||
0 commit comments