Adding mise.toml for versioning. (#1625)

Author: pose

.github/workflows/test-provider-ci.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Checkout Repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       - name: Install golangci-lint
-        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8
         with:
           working-directory: provider-ci
       - name: Configure git

README.md

@@ -25,10 +25,12 @@ This repository has the following components:
 
 The following tools are required for generating and deploying GitHub Actions workflows:
 
-- [Make](https://www.gnu.org/software/make/)
-- [npm](https://www.npmjs.com/)
-- [golangci-lint](https://golangci-lint.run/)
-- [shellcheck](https://github.com/koalaman/shellcheck)
+* [Mise](https://mise.jdx.dev/)
+
+Dependencies required are modeled on `mise.toml`. Run `mise install` and `mise
+settings experimental=true` (required for Go binaries such as `golangci-lint`
+and `pulumictl`) to fetch and install them. Finally, run `mise env` to check if
+env variables are being set correctly.
 
 ## Building
 

mise.toml

@@ -0,0 +1,9 @@
+[tools]
+
+go = '1.21'
+golangci-lint = '2.2.2'
+node = 'latest'
+pulumi = 'latest'
+yarn = '1.22.22'
+dotnet = '8'
+shellcheck = '0.10.0'

provider-ci/internal/pkg/contract/contract.go

@@ -0,0 +1,9 @@
+package contract
+
+import "fmt"
+
+func IgnoreError(f func() error) {
+	if err := f(); err != nil {
+		fmt.Printf("Explicitly ignoring and discarding error: %v", err)
+	}
+}

provider-ci/internal/pkg/generate.go

@@ -12,6 +12,7 @@ import (
 	"text/template"
 
 	"github.com/Masterminds/sprig"
+	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/contract"
 	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/migrations"
 	"gopkg.in/yaml.v3"
 )
@@ -293,7 +294,7 @@ func renderTemplateFile(tmpl *template.Template, outPath string, ctx templateCon
 	if err != nil {
 		return err
 	}
-	defer outFile.Close()
+	defer contract.IgnoreError(outFile.Close)
 
 	_, err = io.Copy(outFile, &outData)
 	if err != nil {

provider-ci/internal/pkg/migrations/fixupBridgeImports.go

@@ -7,6 +7,8 @@ import (
 	"os/exec"
 	"path/filepath"
 	"strings"
+
+	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/contract"
 )
 
 //go:embed fixupBridgeImports.patch
@@ -25,7 +27,7 @@ func (fixupBridgeImports) Migrate(templateName, outDir string) error {
 	if err != nil {
 		return fmt.Errorf("error writing patch file: %w", err)
 	}
-	defer cleanup()
+	defer contract.IgnoreError(cleanup)
 
 	patchCmd := exec.Command("go", "run", "github.com/uber-go/[email protected]", "-p", path, "./provider/resources.go")
 	patchCmd.Stdout = os.Stdout

provider-ci/internal/pkg/migrations/migrations.go

@@ -4,6 +4,8 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+
+	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/contract"
 )
 
 type Migration interface {
@@ -34,7 +36,7 @@ func Migrate(templateName, outDir string) error {
 }
 
 // Returns the path to the temporary file and a function to clean it up, or an error.
-func writeTempFile(name, content string) (string, func(), error) {
+func writeTempFile(name, content string) (string, func() error, error) {
 	dir, err := os.MkdirTemp(os.TempDir(), "pulumi-provider-ci-migration-files")
 	if err != nil {
 		return "", nil, err
@@ -44,7 +46,7 @@ func writeTempFile(name, content string) (string, func(), error) {
 	if err != nil {
 		return "", nil, err
 	}
-	defer f.Close()
+	defer contract.IgnoreError(f.Close)
 	_, err = f.WriteString(content)
-	return path, func() { os.Remove(f.Name()) }, err
+	return path, func() error { return os.Remove(f.Name()) }, err
 }

provider-ci/internal/pkg/migrations/removeExplicitSDKDependency.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+
+	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/contract"
 )
 
 //go:embed removeExplicitSDKDependency.patch
@@ -23,7 +25,7 @@ func (removeExplicitSDKDependency) Migrate(templateName, outDir string) error {
 	if err != nil {
 		return fmt.Errorf("error writing patch file: %w", err)
 	}
-	defer cleanup()
+	defer contract.IgnoreError(cleanup)
 
 	patchCmd := exec.Command("go", "run", "github.com/uber-go/[email protected]", "-p", path, "./provider/resources.go")
 	patchCmd.Stdout = os.Stdout

provider-ci/internal/pkg/migrations/updateToDotnet8.go

@@ -7,6 +7,7 @@ import (
 	"regexp"
 
 	"github.com/bitfield/script"
+	"github.com/pulumi/ci-mgmt/provider-ci/internal/pkg/contract"
 )
 
 type updateToDotnet8 struct{}
@@ -44,7 +45,7 @@ func (updateToDotnet8) Migrate(templateName, outDir string) error {
 // This is useful for reading the content of a file and then writing back to that same file.
 func FileContent(path string) *script.Pipe {
 	p := script.File(path)
-	defer p.Close()
+	defer contract.IgnoreError(p.Close)
 	s, err := p.String()
 	if err != nil {
 		r := script.NewPipe()