Skip to content

Commit 928f9fa

Browse files
authored
Fix a couple of GCP examples (#2196)
Fixes pulumi/pulumi-gcp#3317
2 parents 6946a84 + ffcfca7 commit 928f9fa

File tree

5 files changed

+16
-6
lines changed

5 files changed

+16
-6
lines changed

gcp-cs-functions/FunctionsStack.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ class FunctionsStack : Stack
88
{
99
public FunctionsStack()
1010
{
11-
var bucket = new Bucket("bucket");
11+
var bucket = new Bucket("bucket", new BucketArgs
12+
{
13+
Location = "US"
14+
});
1215

1316
var bucketObject = new BucketObject("python-zip", new BucketObjectArgs
1417
{

gcp-go-functions-raw/main.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import (
99
func main() {
1010
pulumi.Run(func(ctx *pulumi.Context) error {
1111
// Create a bucket.
12-
bucket, err := storage.NewBucket(ctx, "bucket", nil)
12+
bucket, err := storage.NewBucket(ctx, "bucket", &storage.BucketArgs{
13+
Location: pulumi.String("US"),
14+
})
1315
if err != nil {
1416
return err
1517
}
@@ -27,7 +29,7 @@ func main() {
2729
// Set arguments for creating the function resource.
2830
args := &cloudfunctions.FunctionArgs{
2931
SourceArchiveBucket: bucket.Name,
30-
Runtime: pulumi.String("python37"),
32+
Runtime: pulumi.String("python310"),
3133
SourceArchiveObject: bucketObject.Name,
3234
EntryPoint: pulumi.String("handler"),
3335
TriggerHttp: pulumi.Bool(true),

gcp-go-functions/main.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import (
99
func main() {
1010
pulumi.Run(func(ctx *pulumi.Context) error {
1111
// Create a bucket.
12-
bucket, err := storage.NewBucket(ctx, "bucket", nil)
12+
bucket, err := storage.NewBucket(ctx, "bucket", &storage.BucketArgs{
13+
Location: pulumi.String("US"),
14+
})
1315
if err != nil {
1416
return err
1517
}

gcp-go-gke/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func main() {
5959
}
6060
_, err = appsv1.NewDeployment(ctx, "app-dep", &appsv1.DeploymentArgs{
6161
Metadata: &metav1.ObjectMetaArgs{
62-
Namespace: namespace.Metadata.Elem().Name(),
62+
Namespace: namespace.Metadata.Name(),
6363
},
6464
Spec: appsv1.DeploymentSpecArgs{
6565
Selector: &metav1.LabelSelectorArgs{
@@ -86,7 +86,7 @@ func main() {
8686

8787
service, err := corev1.NewService(ctx, "app-service", &corev1.ServiceArgs{
8888
Metadata: &metav1.ObjectMetaArgs{
89-
Namespace: namespace.Metadata.Elem().Name(),
89+
Namespace: namespace.Metadata.Name(),
9090
Labels: appLabels,
9191
},
9292
Spec: &corev1.ServiceSpecArgs{

gcp-go-webserver/main.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ func main() {
1818

1919
computeFirewall, err := compute.NewFirewall(ctx, "firewall",
2020
&compute.FirewallArgs{
21+
SourceTags: pulumi.StringArray{
22+
pulumi.String("web"),
23+
},
2124
Network: computeNetwork.SelfLink,
2225
Allows: &compute.FirewallAllowArray{
2326
&compute.FirewallAllowArgs{

0 commit comments

Comments
 (0)