Use provided.al2 AWS Go Lambda runtime#2175
Open
qsweber wants to merge 2 commits intopulumi:masterfrom
Open
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AWS Go Lambda example to use the new provided.al2 runtime, adjusts handler naming, and aligns the Pulumi AWS API call with its updated signature.
- Call
aws.GetCallerIdentitywith explicit args. - Change the Lambda Function runtime to
provided.al2and Handler tobootstrap. - Update build/zip commands in README and Makefile to output the
bootstrapbinary.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aws-go-lambda-gateway/main.go | Updated GetCallerIdentity call and FunctionArgs (Handler, Runtime) |
| aws-go-lambda-gateway/README.md | Changed build commands to produce bootstrap binary |
| aws-go-lambda-gateway/Makefile | Updated build and zip steps to reference bootstrap |
Comments suppressed due to low confidence (2)
aws-go-lambda-gateway/main.go:13
- [nitpick] The variable
accountholds the caller identity. Consider renaming it toidentityorcallerIdentityfor clearer intent.
account, err := aws.GetCallerIdentity(ctx, &aws.GetCallerIdentityArgs{}, nil)
aws-go-lambda-gateway/main.go:13
- The third argument (
nil) passed to the variadic options inGetCallerIdentitymay not compile. Either omit it or pass validpulumi.InvokeOptionvalues.
account, err := aws.GetCallerIdentity(ctx, &aws.GetCallerIdentityArgs{}, nil)
Contributor
|
/run-example-tests |
Contributor
|
Hey @qsweber — this now has merge conflicts after some go_modules PRs landed. Could you rebase against master? The actual code change still looks good, just needs the go.mod/go.sum conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #1677