Skip to content

Use provided.al2 AWS Go Lambda runtime#2175

Open
qsweber wants to merge 2 commits intopulumi:masterfrom
qsweber:fix-aws-go-lambda-gateway
Open

Use provided.al2 AWS Go Lambda runtime#2175
qsweber wants to merge 2 commits intopulumi:masterfrom
qsweber:fix-aws-go-lambda-gateway

Conversation

@qsweber
Copy link

@qsweber qsweber commented May 7, 2025

Inspired by #1677

@github-actions
Copy link

github-actions bot commented May 7, 2025

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@rshade rshade requested a review from Copilot July 8, 2025 17:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AWS Go Lambda example to use the new provided.al2 runtime, adjusts handler naming, and aligns the Pulumi AWS API call with its updated signature.

  • Call aws.GetCallerIdentity with explicit args.
  • Change the Lambda Function runtime to provided.al2 and Handler to bootstrap.
  • Update build/zip commands in README and Makefile to output the bootstrap binary.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
aws-go-lambda-gateway/main.go Updated GetCallerIdentity call and FunctionArgs (Handler, Runtime)
aws-go-lambda-gateway/README.md Changed build commands to produce bootstrap binary
aws-go-lambda-gateway/Makefile Updated build and zip steps to reference bootstrap
Comments suppressed due to low confidence (2)

aws-go-lambda-gateway/main.go:13

  • [nitpick] The variable account holds the caller identity. Consider renaming it to identity or callerIdentity for clearer intent.
		account, err := aws.GetCallerIdentity(ctx, &aws.GetCallerIdentityArgs{}, nil)

aws-go-lambda-gateway/main.go:13

  • The third argument (nil) passed to the variadic options in GetCallerIdentity may not compile. Either omit it or pass valid pulumi.InvokeOption values.
		account, err := aws.GetCallerIdentity(ctx, &aws.GetCallerIdentityArgs{}, nil)

@dirien
Copy link
Contributor

dirien commented Mar 21, 2026

/run-example-tests

@dirien
Copy link
Contributor

dirien commented Mar 21, 2026

Hey @qsweber — this now has merge conflicts after some go_modules PRs landed. Could you rebase against master? The actual code change still looks good, just needs the go.mod/go.sum conflicts resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants