@@ -10,7 +10,7 @@ Beyond a mechanical revert, during v5.74.0 release resolution there were some co
1010resolved in favor of upstream.
1111
1212diff --git a/internal/service/rds/proxy.go b/internal/service/rds/proxy.go
13- index 5845e8cfd49..a2bc35373e9 100644
13+ index 07db1160be0..2f0f7076d4e 100644
1414--- a/internal/service/rds/proxy.go
1515+++ b/internal/service/rds/proxy.go
1616@@ -19,7 +19,6 @@ import (
@@ -27,7 +27,7 @@ index 5845e8cfd49..a2bc35373e9 100644
2727 "auth": {
2828- Type: schema.TypeSet,
2929+ Type: schema.TypeList,
30- Required : true,
30+ Optional : true,
3131 Elem: &schema.Resource{
3232 Schema: map[string]*schema.Schema{
3333@@ -88,7 +87,6 @@ func resourceProxy() *schema.Resource {
@@ -38,26 +38,8 @@ index 5845e8cfd49..a2bc35373e9 100644
3838 },
3939 "debug_logging": {
4040 Type: schema.TypeBool,
41- @@ -147,7 +145,7 @@ func resourceProxyCreate(ctx context.Context, d *schema.ResourceData, meta any)
42-
43- name := d.Get(names.AttrName).(string)
44- input := &rds.CreateDBProxyInput{
45- - Auth: expandUserAuthConfigs(d.Get("auth").(*schema.Set).List()),
46- + Auth: expandUserAuthConfigs(d.Get("auth").([]interface{})),
47- DBProxyName: aws.String(name),
48- EngineFamily: types.EngineFamily(d.Get("engine_family").(string)),
49- RoleArn: aws.String(d.Get(names.AttrRoleARN).(string)),
50- @@ -224,7 +222,7 @@ func resourceProxyUpdate(ctx context.Context, d *schema.ResourceData, meta any)
51- if d.HasChangesExcept(names.AttrTags, names.AttrTagsAll) {
52- oName, nName := d.GetChange(names.AttrName)
53- input := &rds.ModifyDBProxyInput{
54- - Auth: expandUserAuthConfigs(d.Get("auth").(*schema.Set).List()),
55- + Auth: expandUserAuthConfigs(d.Get("auth").([]interface{})),
56- DBProxyName: aws.String(oName.(string)),
57- DebugLogging: aws.Bool(d.Get("debug_logging").(bool)),
58- NewDBProxyName: aws.String(nName.(string)),
5941diff --git a/internal/service/rds/proxy_test.go b/internal/service/rds/proxy_test.go
60- index 884f83084b8..0856302c30f 100644
42+ index 81262141b61..f649b4623a4 100644
6143--- a/internal/service/rds/proxy_test.go
6244+++ b/internal/service/rds/proxy_test.go
6345@@ -40,12 +40,13 @@ func TestAccRDSProxy_basic(t *testing.T) {
@@ -74,8 +56,8 @@ index 884f83084b8..0856302c30f 100644
7456+
7557 resource.TestCheckTypeSetElemNestedAttrs(resourceName, "auth.*", map[string]string{
7658 "auth_scheme": "SECRETS",
77- "client_password_auth_type": "MYSQL_NATIVE_PASSWORD ",
78- @@ -393 ,10 +394 ,7 @@ func TestAccRDSProxy_authIAMAuth(t *testing.T) {
59+ "client_password_auth_type": "MYSQL_CACHING_SHA2_PASSWORD ",
60+ @@ -394 ,10 +395 ,7 @@ func TestAccRDSProxy_authIAMAuth(t *testing.T) {
7961 Config: testAccProxyConfig_authIAMAuth(rName, iamAuth),
8062 Check: resource.ComposeTestCheckFunc(
8163 testAccCheckProxyExists(ctx, resourceName, &dbProxy),
@@ -87,7 +69,7 @@ index 884f83084b8..0856302c30f 100644
8769 ),
8870 },
8971 },
90- @@ -455 ,6 +453 ,8 @@ func TestAccRDSProxy_tags(t *testing.T) {
72+ @@ -547 ,6 +545 ,8 @@ func TestAccRDSProxy_tags(t *testing.T) {
9173 var dbProxy types.DBProxy
9274 resourceName := "aws_db_proxy.test"
9375 rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
@@ -96,7 +78,7 @@ index 884f83084b8..0856302c30f 100644
9678
9779 resource.ParallelTest(t, resource.TestCase{
9880 PreCheck: func() { acctest.PreCheck(ctx, t); testAccDBProxyPreCheck(ctx, t) },
99- @@ -463 ,7 +463 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
81+ @@ -555 ,7 +555 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
10082 CheckDestroy: testAccCheckProxyDestroy(ctx),
10183 Steps: []resource.TestStep{
10284 {
@@ -105,7 +87,7 @@ index 884f83084b8..0856302c30f 100644
10587 Check: resource.ComposeTestCheckFunc(
10688 testAccCheckProxyExists(ctx, resourceName, &dbProxy),
10789 resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
108- @@ -476 ,7 +476 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
90+ @@ -568 ,7 +568 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
10991 ImportStateVerify: true,
11092 },
11193 {
@@ -114,7 +96,7 @@ index 884f83084b8..0856302c30f 100644
11496 Check: resource.ComposeTestCheckFunc(
11597 testAccCheckProxyExists(ctx, resourceName, &dbProxy),
11698 resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "2"),
117- @@ -485 ,7 +485 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
99+ @@ -577 ,7 +577 ,7 @@ func TestAccRDSProxy_tags(t *testing.T) {
118100 ),
119101 },
120102 {
@@ -123,7 +105,7 @@ index 884f83084b8..0856302c30f 100644
123105 Check: resource.ComposeTestCheckFunc(
124106 testAccCheckProxyExists(ctx, resourceName, &dbProxy),
125107 resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
126- @@ -585 ,7 +585 ,7 @@ func testAccCheckProxyExists(ctx context.Context, n string, v *types.DBProxy) re
108+ @@ -677 ,7 +677 ,7 @@ func testAccCheckProxyExists(ctx context.Context, n string, v *types.DBProxy) re
127109 }
128110 }
129111
@@ -132,7 +114,7 @@ index 884f83084b8..0856302c30f 100644
132114 return fmt.Sprintf(`
133115 # Secrets Manager setup
134116
135- @@ -675 ,14 +675 ,14 @@ resource "aws_subnet" "test" {
117+ @@ -767 ,14 +767 ,14 @@ resource "aws_subnet" "test" {
136118 }
137119
138120 func testAccProxyConfig_basic(rName string) string {
@@ -149,7 +131,7 @@ index 884f83084b8..0856302c30f 100644
149131 debug_logging = false
150132 engine_family = "MYSQL"
151133 idle_client_timeout = 1800
152- @@ -697 ,19 +697 ,23 @@ resource "aws_db_proxy" "test" {
134+ @@ -789 ,19 +789 ,23 @@ resource "aws_db_proxy" "test" {
153135 iam_auth = "DISABLED"
154136 secret_arn = aws_secretsmanager_secret.test.arn
155137 }
@@ -176,7 +158,7 @@ index 884f83084b8..0856302c30f 100644
176158 engine_family = "MYSQL"
177159 role_arn = aws_iam_role.test.arn
178160 vpc_security_group_ids = [aws_security_group.test.id]
179- @@ -722 ,18 +726 ,18 @@ resource "aws_db_proxy" "test" {
161+ @@ -814 ,18 +818 ,18 @@ resource "aws_db_proxy" "test" {
180162 secret_arn = aws_secretsmanager_secret.test.arn
181163 }
182164 }
@@ -198,7 +180,7 @@ index 884f83084b8..0856302c30f 100644
198180 debug_logging = %[2]t
199181 engine_family = "MYSQL"
200182 role_arn = aws_iam_role.test.arn
201- @@ -746 ,18 +750 ,18 @@ resource "aws_db_proxy" "test" {
183+ @@ -838 ,18 +842 ,18 @@ resource "aws_db_proxy" "test" {
202184 secret_arn = aws_secretsmanager_secret.test.arn
203185 }
204186 }
@@ -220,7 +202,7 @@ index 884f83084b8..0856302c30f 100644
220202 idle_client_timeout = %[2]d
221203 engine_family = "MYSQL"
222204 role_arn = aws_iam_role.test.arn
223- @@ -770 ,18 +774 ,18 @@ resource "aws_db_proxy" "test" {
205+ @@ -862 ,18 +866 ,18 @@ resource "aws_db_proxy" "test" {
224206 secret_arn = aws_secretsmanager_secret.test.arn
225207 }
226208 }
@@ -242,7 +224,7 @@ index 884f83084b8..0856302c30f 100644
242224 require_tls = %[2]t
243225 engine_family = "MYSQL"
244226 role_arn = aws_iam_role.test.arn
245- @@ -794 ,18 +798 ,18 @@ resource "aws_db_proxy" "test" {
227+ @@ -886 ,18 +890 ,18 @@ resource "aws_db_proxy" "test" {
246228 secret_arn = aws_secretsmanager_secret.test.arn
247229 }
248230 }
@@ -264,7 +246,7 @@ index 884f83084b8..0856302c30f 100644
264246 engine_family = "MYSQL"
265247 role_arn = aws_iam_role.test2.arn
266248 vpc_subnet_ids = aws_subnet.test[*].id
267- @@ -818 ,8 +822 ,10 @@ resource "aws_db_proxy" "test" {
249+ @@ -910 ,8 +914 ,10 @@ resource "aws_db_proxy" "test" {
268250 }
269251 }
270252
@@ -276,7 +258,7 @@ index 884f83084b8..0856302c30f 100644
276258 assume_role_policy = data.aws_iam_policy_document.assume.json
277259 }
278260
279- @@ -827 ,18 +833 ,18 @@ resource "aws_iam_role_policy" "test2" {
261+ @@ -919 ,18 +925 ,18 @@ resource "aws_iam_role_policy" "test2" {
280262 role = aws_iam_role.test.id
281263 policy = data.aws_iam_policy_document.test.json
282264 }
@@ -298,7 +280,7 @@ index 884f83084b8..0856302c30f 100644
298280 engine_family = "MYSQL"
299281 role_arn = aws_iam_role.test.arn
300282 vpc_security_group_ids = [aws_security_group.test2.id]
301- @@ -853 ,25 +859 ,21 @@ resource "aws_db_proxy" "test" {
283+ @@ -945 ,25 +951 ,21 @@ resource "aws_db_proxy" "test" {
302284 }
303285
304286 resource "aws_security_group" "test2" {
@@ -328,7 +310,7 @@ index 884f83084b8..0856302c30f 100644
328310 engine_family = "MYSQL"
329311 role_arn = aws_iam_role.test.arn
330312 vpc_security_group_ids = [aws_security_group.test.id]
331- @@ -879 ,23 +881 ,23 @@ resource "aws_db_proxy" "test" {
313+ @@ -971 ,23 +973 ,23 @@ resource "aws_db_proxy" "test" {
332314
333315 auth {
334316 auth_scheme = "SECRETS"
@@ -356,7 +338,7 @@ index 884f83084b8..0856302c30f 100644
356338 engine_family = "MYSQL"
357339 role_arn = aws_iam_role.test.arn
358340 require_tls = true
359- @@ -905 ,22 +907 ,22 @@ resource "aws_db_proxy" "test" {
341+ @@ -997 ,22 +999 ,22 @@ resource "aws_db_proxy" "test" {
360342 auth {
361343 auth_scheme = "SECRETS"
362344 description = "test"
@@ -383,7 +365,7 @@ index 884f83084b8..0856302c30f 100644
383365 engine_family = "MYSQL"
384366 role_arn = aws_iam_role.test.arn
385367 vpc_security_group_ids = [aws_security_group.test.id]
386- @@ -944 ,7 +946 ,7 @@ resource "aws_db_proxy" "test" {
368+ @@ -1036 ,7 +1038 ,7 @@ resource "aws_db_proxy" "test" {
387369 }
388370
389371 resource "aws_secretsmanager_secret" "test2" {
@@ -392,13 +374,64 @@ index 884f83084b8..0856302c30f 100644
392374 recovery_window_in_days = 0
393375 }
394376
395- @@ -952,46 +954 ,18 @@ resource "aws_secretsmanager_secret_version" "test2" {
377+ @@ -1044,97 +1046 ,18 @@ resource "aws_secretsmanager_secret_version" "test2" {
396378 secret_id = aws_secretsmanager_secret.test2.id
397379 secret_string = "{\"username\":\"db_user\",\"password\":\"db_user_password\"}"
398380 }
399381- `, rName, nName))
400382- }
401383-
384+ - func testAccProxyConfig_defaultAuthSchemeIAMAUTH(rName string) string {
385+ - return acctest.ConfigCompose(testAccProxyConfig_base(rName), fmt.Sprintf(`
386+ - resource "aws_db_proxy" "test" {
387+ - depends_on = [
388+ - aws_secretsmanager_secret_version.test,
389+ - aws_iam_role_policy.test
390+ - ]
391+ -
392+ - name = %[1]q
393+ - debug_logging = false
394+ - engine_family = "MYSQL"
395+ - idle_client_timeout = 1800
396+ - require_tls = true
397+ - role_arn = aws_iam_role.test.arn
398+ - vpc_security_group_ids = [aws_security_group.test.id]
399+ - vpc_subnet_ids = aws_subnet.test[*].id
400+ -
401+ - default_auth_scheme = "IAM_AUTH"
402+ - }
403+ - `, rName))
404+ - }
405+ -
406+ - func testAccProxyConfig_defaultAuthSchemeNONE(rName string) string {
407+ - return acctest.ConfigCompose(testAccProxyConfig_base(rName), fmt.Sprintf(`
408+ - resource "aws_db_proxy" "test" {
409+ - depends_on = [
410+ - aws_secretsmanager_secret_version.test,
411+ - aws_iam_role_policy.test
412+ - ]
413+ -
414+ - name = %[1]q
415+ - debug_logging = false
416+ - engine_family = "MYSQL"
417+ - idle_client_timeout = 1800
418+ - require_tls = true
419+ - role_arn = aws_iam_role.test.arn
420+ - vpc_security_group_ids = [aws_security_group.test.id]
421+ - vpc_subnet_ids = aws_subnet.test[*].id
422+ -
423+ - auth {
424+ - auth_scheme = "SECRETS"
425+ - description = "test"
426+ - iam_auth = "DISABLED"
427+ - secret_arn = aws_secretsmanager_secret.test.arn
428+ - }
429+ -
430+ - default_auth_scheme = "NONE"
431+ - }
432+ - `, rName))
433+ - }
434+ -
402435- func testAccProxyConfig_tags1(rName, tagKey1, tagValue1 string) string {
403436- return acctest.ConfigCompose(testAccProxyConfig_base(rName), fmt.Sprintf(`
404437- resource "aws_db_proxy" "test" {
@@ -443,7 +476,7 @@ index 884f83084b8..0856302c30f 100644
443476 engine_family = "MYSQL"
444477 role_arn = aws_iam_role.test.arn
445478 vpc_security_group_ids = [aws_security_group.test.id]
446- @@ -1005 ,9 +979 ,8 @@ resource "aws_db_proxy" "test" {
479+ @@ -1148 ,9 +1071 ,8 @@ resource "aws_db_proxy" "test" {
447480 }
448481
449482 tags = {
0 commit comments