Skip to content

Commit 3cce3df

Browse files
authored
Remove rds.db.Proxy revert patch (#5915)
This patch was added a while ago to fix a panic in the bridge. We accidentally broke it [a couple of releases ago](https://github.com/pulumi/pulumi-aws/pull/5872/files#diff-621a91eb03679b13105bec390bcc509e1358fd96caff45b2437709e3d526c775). While fixing the patch, I went ahead and tested what would happen if we removed the patch altogether and it worked. It looks like the reason we didn't catch this regression in tests is that our test only ran in preview. This must have been good enough to catch the original panic, but wasn't good enough to catch this regression. I've updated the tests to perform actual deployments and added another test case that was mentioned in the original issue. closes #3968 fixes #5901
1 parent c785a6f commit 3cce3df

11 files changed

+20
-494
lines changed

examples/examples_nodejs_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,8 +1055,8 @@ func TestRegress3835(t *testing.T) {
10551055
opttest.YarnLink("@pulumi/aws"),
10561056
}
10571057
test := pulumitest.NewPulumiTest(t, dir, options...)
1058-
result := test.Preview(t)
1059-
t.Logf("#%v", result.ChangeSummary)
1058+
result := test.Up(t)
1059+
t.Logf("#%v", result.Summary)
10601060
}
10611061

10621062
func TestChangingRegion(t *testing.T) {

examples/test-programs/regress-3835/index.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,38 @@ const anotherSubnet = new aws.ec2.Subnet("another-subnet", {
3030
const secret = new aws.secretsmanager.Secret("secret", {});
3131

3232
const example = new aws.rds.Proxy("example", {
33-
name: "example",
3433
debugLogging: false,
3534
engineFamily: "MYSQL",
3635
idleClientTimeout: 1800,
3736
requireTls: true,
3837
roleArn: proxyRole.arn,
3938
vpcSubnetIds: [subnet.id, anotherSubnet.id],
4039
auths: secret.arn.apply(sec => [{
40+
description: 'Postgres Proxy Authentication',
4141
iamAuth: "DISABLED",
4242
authScheme: "SECRETS",
43-
secretArn: sec[0],
43+
secretArn: sec,
4444
}]),
4545
tags: {
4646
Name: "example",
4747
Key: "value",
4848
},
4949
});
5050

51+
const example2 = new aws.rds.Proxy("example2", {
52+
debugLogging: false,
53+
engineFamily: "MYSQL",
54+
idleClientTimeout: 1800,
55+
requireTls: true,
56+
roleArn: proxyRole.arn,
57+
vpcSubnetIds: [subnet.id, anotherSubnet.id],
58+
defaultAuthScheme: 'IAM_AUTH',
59+
auths: [{}],
60+
tags: {
61+
Name: "example",
62+
Key: "value",
63+
},
64+
});
65+
5166
export const exmapleID = example.id;
67+
export const example2ID = example2.id;

0 commit comments

Comments
 (0)