Skip to content

Commit 3d986b5

Browse files
Re-introduce write-only version support fields (#5906)
This pull request removes logic that removed write-only supportive fields from the schema and SDKs. Once pulumi/pulumi-terraform-bridge#3215 has been released and a new bridge version has landed in this provider, write-only fields will be available, and these supportive fields are necessary to use them properly. Until the bridge changes land, fields such as `masterPasswordWoVersion` will not be usable, but they're necessary for the use of `masterPasswordWo` so they should be available before write-only fields are enabled. Fixes #5878 - **Remove logic to keep writeOnly supporting fields from being generated** - **Make schema** - **Build SDKs**
1 parent e3b560d commit 3d986b5

File tree

59 files changed

+1823
-31
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+1823
-31
lines changed

provider/cmd/pulumi-resource-aws/runtime-bridge-metadata.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

provider/cmd/pulumi-resource-aws/schema.json

Lines changed: 114 additions & 0 deletions
Large diffs are not rendered by default.

provider/resources.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import (
2929
"time"
3030
"unicode"
3131

32-
"github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/walk"
33-
3432
"github.com/aws/aws-sdk-go-v2/feature/ec2/imds"
3533
awsbase "github.com/hashicorp/aws-sdk-go-base/v2"
3634
"github.com/mitchellh/go-homedir"
@@ -5656,24 +5654,6 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo {
56565654
}
56575655
}
56585656

5659-
// TODO[pulumi/pulumi-terraform-bridge#2938]
5660-
// Currently, the bridge omits write-only attributes from being written to a provider schema.
5661-
// In this provider, we additionally have some attributes called things like "has_value_wo" or "version_wo".
5662-
// To avoid user confusion, we omit these here as well.
5663-
tfbridge.MustTraverseProperties(&prov, "write-only-supporting-properties",
5664-
func(propertyVisitInfo tfbridge.PropertyVisitInfo) (tfbridge.PropertyVisitResult, error) {
5665-
schemaPath := propertyVisitInfo.SchemaPath()
5666-
if key, ok := schemaPath[len(schemaPath)-1].(walk.GetAttrStep); ok {
5667-
if strings.Contains(key.Name, "_wo_") || strings.HasSuffix(key.Name, "_wo") {
5668-
propertyVisitInfo.SchemaInfo().Omit = true
5669-
// Since we're omitting these properties entirely, they have no effect at runtime.
5670-
return tfbridge.PropertyVisitResult{HasEffect: false}, nil
5671-
}
5672-
}
5673-
return tfbridge.PropertyVisitResult{}, nil
5674-
},
5675-
)
5676-
56775657
setAutonaming(&prov)
56785658

56795659
prov.MustApplyAutoAliases()

sdk/dotnet/Bedrock/AgentcoreApiKeyCredentialProvider.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/DocDB/Cluster.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/Rds/Cluster.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/Rds/Instance.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/RedShift/Cluster.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/RedshiftServerless/Namespace.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/SecretsManager/SecretVersion.cs

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)