Skip to content

Commit a71ee7b

Browse files
Remove skipping examples gen for recursive resources (#5727)
This pull request reverts the skipping of examples generation for the following three resources: - `wafv2:RuleGroup` - `wafv2:Acl` - `appsync:GraphQLApi` It appears from the typical duration for the `make schema` (~30min) and `make build_go` (~30min) CI runs on this pull request, that the conditions for #2598 have been met. NOTE: current CI timeouts are unrelated to the changes. This pull request closes: - #5691 - #2598 - **Unskip examples generation and make schema for 3 resources** - **make SDKs**
1 parent 8a3bc0e commit a71ee7b

File tree

18 files changed

+4881
-19
lines changed

18 files changed

+4881
-19
lines changed

provider/cmd/pulumi-resource-aws/schema.json

Lines changed: 4 additions & 1 deletion
Large diffs are not rendered by default.

provider/resources.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5651,14 +5651,6 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo {
56515651
}
56525652
}
56535653

5654-
prov.SkipExamples = func(args tfbridge.SkipExamplesArgs) bool {
5655-
// These examples hang on Go generation. Issue tracking to unblock:
5656-
// https://github.com/pulumi/pulumi-aws/issues/2598
5657-
return args.ExamplePath == "#/resources/aws:wafv2/ruleGroup:RuleGroup" ||
5658-
args.ExamplePath == "#/resources/aws:wafv2/webAcl:WebAcl" ||
5659-
args.ExamplePath == "#/resources/aws:appsync/graphQLApi:GraphQLApi"
5660-
}
5661-
56625654
// TODO[pulumi/pulumi-terraform-bridge#2938]
56635655
// Currently, the bridge omits write-only attributes from being written to a provider schema.
56645656
// In this provider, we additionally have some attributes called things like "has_value_wo" or "version_wo".

sdk/dotnet/AppSync/GraphQLApi.cs

Lines changed: 265 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/dotnet/WafV2/RuleGroup.cs

Lines changed: 68 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)