From 6320255e04894a848c3df575423393d49bae8a38 Mon Sep 17 00:00:00 2001 From: "Matthew (Matt) Jeffryes" Date: Fri, 21 Mar 2025 15:58:12 -0700 Subject: [PATCH 1/5] Create stale_issues.yaml Dry run for adding an action that would comment on very old issues and apply the awaiting-feedback label. (see [Automate comments on stale issues](https://docs.google.com/document/d/1UCGvPZ9m7vHpl5E6jIt8PUV7J6SVGOf-wMHrB4OfBt0/edit?tab=t.0#heading=h.vmiybe9heukw), [Stale Issues Proposal](https://docs.google.com/document/d/1dw7ehY3kchsyEO_M5z9vcpleHNEzwpTdl2G-8UnmpKQ/edit?tab=t.0)) --- .github/workflows/stale_issues.yaml | 45 +++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 .github/workflows/stale_issues.yaml diff --git a/.github/workflows/stale_issues.yaml b/.github/workflows/stale_issues.yaml new file mode 100644 index 00000000000..365d051b047 --- /dev/null +++ b/.github/workflows/stale_issues.yaml @@ -0,0 +1,45 @@ +name: "Comment on stale issues" + +# Controls when the action will run. +on: + pull_request: {} # for testing only + #schedule: + # - cron: "46 4 * * *" # run once per day + +jobs: + cleanup: + runs-on: ubuntu-latest + name: Stale issue job + steps: + - uses: aws-actions/stale-issue-cleanup@v3 + with: + issueTypes: issues # only look at issues (ignore pull-requests) + + # Setting messages to an empty string causes the automation to skip that category + ancient-issue-message: "Unfortunately, it looks like this issue hasn't seen any updates in a while. If you're still experiencing this issue, could you leave a quick comment to let us know so we can prioritize it?" + ancient-pr-message: "" + stale-issue-message: "" + stale-pr-message: "" + + # These labels are required + stale-issue-label: awaiting-feedback # somewhat confusingly, this is also used for when labeling "ancient" issues + exempt-issue-labels: kind/enhancement,kind/task,kind/epic, kind/engineering # only run on kind/bug for now + stale-pr-label: no-pr-activity # unused because we aren't processing PRs + exempt-pr-labels: awaiting-approval # unused because we aren't processing PRs + response-requested-label: response-requested # unused because we don't set a "stale-issue-message" above + + # Issue timing + days-before-close: 10000 # this action lacks the option not to close, so just set this indefinitly far in the future + days-before-ancient: 180 # 6 months + + # If you don't want to mark a issue as being ancient based on a + # threshold of "upvotes", you can set this here. An "upvote" is + # the total number of +1, heart, hooray, and rocket reactions + # on an issue. + minimum-upvotes-to-exempt: 2 + + repo-token: ${{ secrets.GITHUB_TOKEN }} + loglevel: DEBUG + + # Set dry-run to true to not perform label or close actions. + dry-run: true From bf56923ed7a1e55c40e4e44f8d827e7b0f1f1e66 Mon Sep 17 00:00:00 2001 From: "Matthew (Matt) Jeffryes" Date: Fri, 21 Mar 2025 16:03:20 -0700 Subject: [PATCH 2/5] Update .github/workflows/stale_issues.yaml --- .github/workflows/stale_issues.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale_issues.yaml b/.github/workflows/stale_issues.yaml index 365d051b047..1fa02544617 100644 --- a/.github/workflows/stale_issues.yaml +++ b/.github/workflows/stale_issues.yaml @@ -23,7 +23,7 @@ jobs: # These labels are required stale-issue-label: awaiting-feedback # somewhat confusingly, this is also used for when labeling "ancient" issues - exempt-issue-labels: kind/enhancement,kind/task,kind/epic, kind/engineering # only run on kind/bug for now + exempt-issue-labels: kind/enhancement,kind/task,kind/epic,kind/engineering # only run on kind/bug for now stale-pr-label: no-pr-activity # unused because we aren't processing PRs exempt-pr-labels: awaiting-approval # unused because we aren't processing PRs response-requested-label: response-requested # unused because we don't set a "stale-issue-message" above From 506b138a9cb5267c5caf07e2463bbb7aeb3e453f Mon Sep 17 00:00:00 2001 From: "Matthew (Matt) Jeffryes" Date: Fri, 21 Mar 2025 16:05:35 -0700 Subject: [PATCH 3/5] Update .github/workflows/stale_issues.yaml --- .github/workflows/stale_issues.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale_issues.yaml b/.github/workflows/stale_issues.yaml index 1fa02544617..90801c93a2f 100644 --- a/.github/workflows/stale_issues.yaml +++ b/.github/workflows/stale_issues.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest name: Stale issue job steps: - - uses: aws-actions/stale-issue-cleanup@v3 + - uses: aws-actions/stale-issue-cleanup@d4e71fe22b9ac48fbc6614453edf340d18af5a6e #v7.1.0 with: issueTypes: issues # only look at issues (ignore pull-requests) From 678924427bf5980e8c6f93afccab8fa7c0cd1576 Mon Sep 17 00:00:00 2001 From: "Matthew (Matt) Jeffryes" Date: Fri, 21 Mar 2025 16:08:00 -0700 Subject: [PATCH 4/5] Update .github/workflows/stale_issues.yaml --- .github/workflows/stale_issues.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale_issues.yaml b/.github/workflows/stale_issues.yaml index 90801c93a2f..6faec8bba20 100644 --- a/.github/workflows/stale_issues.yaml +++ b/.github/workflows/stale_issues.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest name: Stale issue job steps: - - uses: aws-actions/stale-issue-cleanup@d4e71fe22b9ac48fbc6614453edf340d18af5a6e #v7.1.0 + - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0 with: issueTypes: issues # only look at issues (ignore pull-requests) From 2d4303d05ed4730cb899ee2b220510bfd0b1e18b Mon Sep 17 00:00:00 2001 From: "Matthew (Matt) Jeffryes" Date: Fri, 21 Mar 2025 16:15:46 -0700 Subject: [PATCH 5/5] Apply suggestions from code review --- .github/workflows/stale_issues.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/stale_issues.yaml b/.github/workflows/stale_issues.yaml index 6faec8bba20..4209e4c3958 100644 --- a/.github/workflows/stale_issues.yaml +++ b/.github/workflows/stale_issues.yaml @@ -13,7 +13,7 @@ jobs: steps: - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0 with: - issueTypes: issues # only look at issues (ignore pull-requests) + issue-types: issues # only look at issues (ignore pull-requests) # Setting messages to an empty string causes the automation to skip that category ancient-issue-message: "Unfortunately, it looks like this issue hasn't seen any updates in a while. If you're still experiencing this issue, could you leave a quick comment to let us know so we can prioritize it?" @@ -23,7 +23,7 @@ jobs: # These labels are required stale-issue-label: awaiting-feedback # somewhat confusingly, this is also used for when labeling "ancient" issues - exempt-issue-labels: kind/enhancement,kind/task,kind/epic,kind/engineering # only run on kind/bug for now + exempt-issue-labels: kind/enhancement,kind/task,kind/epic,kind/engineering, awaiting-upstream # only run on kind/bug for now, ignore awaiting-upstream too. stale-pr-label: no-pr-activity # unused because we aren't processing PRs exempt-pr-labels: awaiting-approval # unused because we aren't processing PRs response-requested-label: response-requested # unused because we don't set a "stale-issue-message" above