Skip to content

Fix lint issues#1133

Merged
blampe merged 1 commit intomasterfrom
blampe/lint-fixes
Feb 4, 2026
Merged

Fix lint issues#1133
blampe merged 1 commit intomasterfrom
blampe/lint-fixes

Conversation

@blampe
Copy link
Contributor

@blampe blampe commented Feb 3, 2026

Lint fixes in preparation of pulumi/ci-mgmt#2024.

@blampe blampe requested review from a team and pose February 3, 2026 22:03
@blampe blampe added this to the 0.132 milestone Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.78%. Comparing base (544de74) to head (b4d95e9).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/provider/remote/proxyConnection.go 0.00% 16 Missing ⚠️
provider/pkg/provider/common/inputs.go 0.00% 10 Missing ⚠️
provider/pkg/provider/remote/commandOutputs.go 0.00% 6 Missing ⚠️
provider/pkg/provider/remote/connection.go 78.57% 6 Missing ⚠️
provider/pkg/provider/remote/copyController.go 16.66% 5 Missing ⚠️
provider/pkg/provider/local/base.go 0.00% 4 Missing ⚠️
provider/pkg/provider/local/commandOutputs.go 0.00% 2 Missing ⚠️
provider/pkg/provider/provider.go 0.00% 2 Missing ⚠️
provider/pkg/provider/remote/commandController.go 60.00% 1 Missing and 1 partial ⚠️
...ider/pkg/provider/util/testutil/test_ssh_server.go 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
+ Coverage   28.36%   28.78%   +0.41%     
==========================================
  Files          25       25              
  Lines         846      879      +33     
==========================================
+ Hits          240      253      +13     
- Misses        557      577      +20     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blampe blampe merged commit 1cfd9e0 into master Feb 4, 2026
22 checks passed
@blampe blampe deleted the blampe/lint-fixes branch February 4, 2026 18:52
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this pull request Feb 10, 2026
Followup to #2018.

* Ship a consistent lint workflow to all providers.
* Ship a consistent `.golangci.yml` to all providers.
* Completely delegate lint in CI to `make lint`.
* Rename `make lint_provider` to `make lint` for consistency across all
providers.

Rolling this out will require resolving some lint errors first. I'll do
a dry run across all providers to see how bad it is first.

- [x] pulumi/pulumi-terraform#948
(pulumi/pulumi-terraform#953)
- [x] pulumi/pulumi-terraform-module#716
- [x] pulumi/pulumi-kubernetes#4124
(pulumi/pulumi-kubernetes#4132)
- [x] pulumi/pulumi-kubernetes-ingress-nginx#517
(pulumi/pulumi-kubernetes-ingress-nginx#521)
- [x] pulumi/pulumi-kubernetes-coredns#613
(pulumi/pulumi-kubernetes-coredns#621)
- [x] pulumi/pulumi-docker-build#752
(pulumi/pulumi-docker-build#755)
- [ ] pulumi/pulumi-kubernetes-cert-manager#839
- [x] pulumi/pulumi-command#1131
(pulumi/pulumi-command#1133)
- [x] pulumi/pulumi-provider-boilerplate#1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants