fix

Author: VenelinMartinov

pkg/pf/tests/diff_test/diff_test.go

@@ -206,10 +206,4 @@ func TestPFDetailedDiffDynamicType(t *testing.T) {
 			ResourceSchema: attributeSchema,
 		}), map[string]cty.Value{"key": cty.NumberVal(big.NewFloat(1))}, map[string]cty.Value{"key": cty.NumberVal(big.NewFloat(1))})
 	})
-
-	t.Run("type change", func(t *testing.T) {
-		crosstests.Diff(t, pb.NewResource(pb.NewResourceArgs{
-			ResourceSchema: attributeSchema,
-		}), map[string]cty.Value{"key": cty.StringVal("value")}, map[string]cty.Value{"key": cty.NumberVal(big.NewFloat(1))})
-	})
 }

pkg/pf/tfbridge/resource_state.go

@@ -251,15 +251,10 @@ func (p *provider) parseAndUpgradeResourceState(
 	}
 
 	// Otherwise fallback to imprecise legacy parsing.
-	tfType := rh.schema.Type(ctx).(tftypes.Object)
 	value, err := convert.EncodePropertyMap(rh.encoder, props)
 	if err != nil {
 		return nil, fmt.Errorf("[pf/tfbridge] Error calling EncodePropertyMap: %w", err)
 	}
-	rawState, err := pfutils.NewRawState(tfType, value)
-	if err != nil {
-		return nil, fmt.Errorf("[pf/tfbridge] Error calling NewRawState: %w", err)
-	}
 
 	// Before EnableRawStateDelta rollout, the behavior used to be to skip the upgrade method in case of an exact
 	// version match. This seems incorrect, but to derisk fixing this problem it is flagged together with
@@ -272,6 +267,13 @@ func (p *provider) parseAndUpgradeResourceState(
 		}, nil
 	}
 
+	tfType := rh.schema.Type(ctx).(tftypes.Object)
+	rawState, err := pfutils.NewRawState(tfType, value)
+	if err != nil {
+		return nil, fmt.Errorf("[pf/tfbridge] Error calling NewRawState: %w", err)
+	}
+
+
 	return p.upgradeResourceState(ctx, rh, rawState, parsedMeta.PrivateState, stateVersion)
 }